From: Matt Mackall <mpm@selenic.com>
To: David Howells <dhowells@redhat.com>
Cc: Aubrey <aubreylee@gmail.com>,
Nick Piggin <nickpiggin@yahoo.com.au>,
linux-kernel@vger.kernel.org, davidm@snapgear.com,
gerg@snapgear.com
Subject: Re: kernel BUGs when removing largish files with the SLOB allocator
Date: Tue, 12 Sep 2006 16:15:00 -0500 [thread overview]
Message-ID: <20060912211500.GH19707@waste.org> (raw)
In-Reply-To: <6626.1158094964@warthog.cambridge.redhat.com>
On Tue, Sep 12, 2006 at 10:02:44PM +0100, David Howells wrote:
> Matt Mackall <mpm@selenic.com> wrote:
>
> > Not sure yet. There's only one user in nommu.c that shouldn't just be
> > changed to ksize() that I can see, and that's the one in
> > show_process_blocks(). That could test for VM_MAPPED_COPY and keep its
> > hands off otherwise.
>
> Hmmm... You're right. However, note binfmt_elf_fdpic(). This calls ksize()
> but should really call kobjsize(). It should not assume that the allocation
> it's been given is of any particular type.
I presume you mean load_elf_fdpic_binary, which is doing:
fullsize = ksize((char *) current->mm->start_brk);
That's a little troubling.
> IIRC ksize() changed purpose at some point.
Uh, nope. ksize doesn't even exist in 2.4 and has always done the same
thing in 2.6.
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2006-09-12 21:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-04 6:56 kernel BUGs when removing largish files with the SLOB allocator Aubrey
2006-09-04 10:21 ` David Howells
2006-09-05 3:52 ` Aubrey
2006-09-05 9:35 ` David Howells
2006-09-06 2:35 ` Aubrey
2006-09-06 3:36 ` Nick Piggin
2006-09-12 8:07 ` Aubrey
2006-09-12 8:54 ` David Howells
2006-09-12 10:53 ` Aubrey
2006-09-12 17:43 ` Matt Mackall
2006-09-12 19:10 ` David Howells
2006-09-12 20:51 ` Matt Mackall
2006-09-12 20:56 ` David Howells
2006-09-12 21:04 ` Matt Mackall
2006-09-12 21:59 ` David Howells
2006-09-13 19:39 ` Matt Mackall
2006-09-13 2:16 ` Nick Piggin
2006-09-13 7:21 ` Aubrey
2006-09-12 19:25 ` David Howells
2006-09-12 20:28 ` Matt Mackall
2006-09-12 21:02 ` David Howells
2006-09-12 21:15 ` Matt Mackall [this message]
2006-09-12 20:49 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060912211500.GH19707@waste.org \
--to=mpm@selenic.com \
--cc=aubreylee@gmail.com \
--cc=davidm@snapgear.com \
--cc=dhowells@redhat.com \
--cc=gerg@snapgear.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox