From: Martin Waitz <tali@admingilde.org>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@redhat.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
Tom Zanussi <zanussi@us.ibm.com>,
ltt-dev@shafik.org, Michel Dagenais <michel.dagenais@polymtl.ca>
Subject: Re: [PATCH 4/11] LTTng-core 0.5.108 : core
Date: Thu, 14 Sep 2006 09:43:06 +0200 [thread overview]
Message-ID: <20060914074306.GQ17042@admingilde.org> (raw)
In-Reply-To: <20060914034308.GE2194@Krystal>
[-- Attachment #1: Type: text/plain, Size: 705 bytes --]
hoi :)
On Wed, Sep 13, 2006 at 11:43:08PM -0400, Mathieu Desnoyers wrote:
> +int ltt_module_register(enum ltt_module_function name, void *function,
> + struct module *owner)
> +{
> + int ret = 0;
> +
> + /* Protect these operations by disallowing them when tracing is
> + * active */
> + if(ltt_traces.num_active_traces) {
> + ret = -EBUSY;
> + goto end;
> + }
what would happen otherwise?
can it happen that someone enables tracing between this check and
the rest of the function?
> + new_trace->transport = transport;
> + new_trace->ops = &transport->ops;
> +
> + err = -new_trace->ops->create_dirs(new_trace);
^ typo or intentional?
--
Martin Waitz
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-09-14 7:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-14 3:43 [PATCH 4/11] LTTng-core 0.5.108 : core Mathieu Desnoyers
2006-09-14 7:43 ` Martin Waitz [this message]
2006-09-14 15:47 ` Mathieu Desnoyers
2006-09-14 14:04 ` Serge E. Hallyn
2006-09-14 15:37 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060914074306.GQ17042@admingilde.org \
--to=tali@admingilde.org \
--cc=akpm@osdl.org \
--cc=gregkh@suse.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ltt-dev@shafik.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=michel.dagenais@polymtl.ca \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=zanussi@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox