From: Arnd Bergmann <arnd@arndb.de>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] Alignment of fields in struct dentry
Date: Fri, 15 Sep 2006 22:44:07 +0200 [thread overview]
Message-ID: <200609152244.07889.arnd@arndb.de> (raw)
In-Reply-To: <20060915102736.GA767@wohnheim.fh-wedel.de>
Am Friday 15 September 2006 12:27 schrieb Jörn Engel:
> -};
> +}__attribute__((aligned(64))); /* make sure the dentry is 128/192 bytes
> + on 32/64 bit independently of config
> + options. d_iname will vary in length
> + a bit. */
I'd guess that a 32 byte alignment is much better here, 64 byte sounds
excessive. It should have the same effect with the current dentry layout
and default config options, but would keep the d_iname length in the
16-44 byte range instead of 16-76 byte as your patch does.
Since all important fields are supposed to be kept in 32 bytes anyway,
they are still either at the start or the end of a given cache line,
but never cross two.
Arnd <><
next prev parent reply other threads:[~2006-09-15 20:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-14 9:31 [RFC] Alignment of fields in struct dentry Jörn Engel
2006-09-14 10:50 ` Jörn Engel
2006-09-14 18:33 ` Andreas Dilger
2006-09-14 21:02 ` Jörn Engel
2006-09-14 21:55 ` Andreas Dilger
2006-09-15 10:27 ` Jörn Engel
2006-09-15 13:41 ` Jörn Engel
2006-09-15 20:44 ` Arnd Bergmann [this message]
2006-09-18 21:24 ` Jörn Engel
2006-09-18 21:54 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200609152244.07889.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox