Re: [PATCH 17/19] iop3xx: define IOP3XX_REG_ADDR[32|16|8] and clean up DMA/AAU defs

Jeff Garzik
2006-09-11T23:55:13Z

Dan Williams wrote:
> From: Dan Williams <dan.j.williams@intel.com>
>
> Also brings the iop3xx registers in line with the format of the iop13xx
> register definitions.
>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>
> include/asm-arm/arch-iop32x/entry-macro.S | 2
> include/asm-arm/arch-iop32x/iop32x.h | 14 +
> include/asm-arm/arch-iop33x/entry-macro.S | 2
> include/asm-arm/arch-iop33x/iop33x.h | 38 ++-
> include/asm-arm/hardware/iop3xx.h | 347 +++++++++++++----------------
> 5 files changed, 188 insertions(+), 215 deletions(-)

Another Linux mantra: "volatile" == hiding a bug. Avoid, please.

Jeff