public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frederik Deweerdt <deweerdt@free.fr>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, gregkh@suse.de
Subject: [-mm patch] missing class_dev to dev conversions
Date: Tue, 19 Sep 2006 17:39:03 +0000	[thread overview]
Message-ID: <20060919173902.GB751@slug> (raw)
In-Reply-To: <20060919012848.4482666d.akpm@osdl.org>

On Tue, Sep 19, 2006 at 01:28:48AM -0700, Andrew Morton wrote:
> 
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc7/2.6.18-rc7-mm1/
> 
Greg,

There are some net drivers that didn't get their class_device converted to
device, as introduced by the gregkh-driver-network-class_device-to-device
patch.
The arm defconfig build thus fails with the following message:

drivers/net/smc91x.c: In function `smc_ethtool_getdrvinfo':
drivers/net/smc91x.c:1713: error: structure has no member named
`class_dev'
make[2]: *** [drivers/net/smc91x.o] Error 1
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

The following patch fixes at91_ether.c, etherh.c, smc911x.c and smc91x.c.

Regards,
Frederik

Signed-off-by: Frederik Deweerdt <frederik.deweerdt@gmail.com>

diff --git a/drivers/net/arm/at91_ether.c b/drivers/net/arm/at91_ether.c
index 95b28aa..0662a72 100644
--- a/drivers/net/arm/at91_ether.c
+++ b/drivers/net/arm/at91_ether.c
@@ -645,7 +645,7 @@ static void at91ether_get_drvinfo(struct
 {
 	strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
 	strlcpy(info->version, DRV_VERSION, sizeof(info->version));
-	strlcpy(info->bus_info, dev->class_dev.dev->bus_id, sizeof(info->bus_info));
+	strlcpy(info->bus_info, dev->dev.parent->bus_id, sizeof(info->bus_info));
 }
 
 static const struct ethtool_ops at91ether_ethtool_ops = {
diff --git a/drivers/net/arm/etherh.c b/drivers/net/arm/etherh.c
index 4ae9897..218380a 100644
--- a/drivers/net/arm/etherh.c
+++ b/drivers/net/arm/etherh.c
@@ -580,7 +580,7 @@ static void etherh_get_drvinfo(struct ne
 {
 	strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
 	strlcpy(info->version, DRV_VERSION, sizeof(info->version));
-	strlcpy(info->bus_info, dev->class_dev.dev->bus_id,
+	strlcpy(info->bus_info, dev->dev.parent->bus_id,
 		sizeof(info->bus_info));
 }
 
diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
index a621b17..b5aafb0 100644
--- a/drivers/net/smc911x.c
+++ b/drivers/net/smc911x.c
@@ -1653,7 +1653,7 @@ smc911x_ethtool_getdrvinfo(struct net_de
 {
 	strncpy(info->driver, CARDNAME, sizeof(info->driver));
 	strncpy(info->version, version, sizeof(info->version));
-	strncpy(info->bus_info, dev->class_dev.dev->bus_id, sizeof(info->bus_info));
+	strncpy(info->bus_info, dev->dev.parent->bus_id, sizeof(info->bus_info));
 }
 
 static int smc911x_ethtool_nwayreset(struct net_device *dev)
diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c
index d7e5643..810157d 100644
--- a/drivers/net/smc91x.c
+++ b/drivers/net/smc91x.c
@@ -1710,7 +1710,7 @@ smc_ethtool_getdrvinfo(struct net_device
 {
 	strncpy(info->driver, CARDNAME, sizeof(info->driver));
 	strncpy(info->version, version, sizeof(info->version));
-	strncpy(info->bus_info, dev->class_dev.dev->bus_id, sizeof(info->bus_info));
+	strncpy(info->bus_info, dev->dev.parent->bus_id, sizeof(info->bus_info));
 }
 
 static int smc_ethtool_nwayreset(struct net_device *dev)

  parent reply	other threads:[~2006-09-19 15:40 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-19  8:28 2.6.18-rc7-mm1 Andrew Morton
2006-09-19 13:08 ` 2.6.18-rc7-mm1 Olivier Galibert
2006-09-19 14:22   ` 2.6.18-rc7-mm1 Greg KH
2006-09-19 14:21 ` 2.6.18-rc7-mm1 Greg KH
2006-09-19 16:36   ` 2.6.18-rc7-mm1 Andrew Morton
2006-09-19 18:36     ` 2.6.18-rc7-mm1 Greg KH
2006-09-19 14:45 ` 2.6.18-rc7-mm1 Martin J. Bligh
2006-09-19 16:31   ` 2.6.18-rc7-mm1 Andrew Morton
2006-09-19 16:57     ` 2.6.18-rc7-mm1 Olaf Hering
2006-09-19 17:00     ` 2.6.18-rc7-mm1 Martin Bligh
2006-09-21 12:55     ` 2.6.18-rc7-mm1 Andy Whitcroft
2006-10-07 20:26       ` 2.6.18-rc7-mm1 Greg KH
2006-10-09 12:31         ` 2.6.18-rc7-mm1 Andy Whitcroft
2006-10-09 16:08           ` 2.6.18-rc7-mm1 Greg KH
2006-09-19 17:39 ` Frederik Deweerdt [this message]
2006-10-04  5:10   ` [-mm patch] missing class_dev to dev conversions Greg KH
2006-09-19 20:25 ` 2.6.18-rc7-mm1 Rafael J. Wysocki
2006-09-19 20:36   ` 2.6.18-rc7-mm1 Andrew Morton
2006-09-19 21:30     ` 2.6.18-rc7-mm1: networking breakage on HPC nx6325 + SUSE 10.1 Rafael J. Wysocki
2006-09-19 22:06       ` Rafael J. Wysocki
2006-09-19 22:06         ` David Miller
2006-09-19 22:30           ` Greg KH
2006-09-19 22:56             ` Rafael J. Wysocki
2006-09-20  2:28               ` Greg KH
2006-09-20  1:31             ` Dmitry Torokhov
2006-09-20  1:03       ` Valdis.Kletnieks
2006-09-20 14:23     ` 2.6.18-rc7-mm1 Mike Galbraith
2006-09-20 13:18       ` 2.6.18-rc7-mm1 Rafael J. Wysocki
2006-09-21  9:44       ` 2.6.18-rc7-mm1 Andi Kleen
2006-09-21 13:11 ` 2.6.18-rc7-mm1 -- ppc64 crash in slab_node ?? Andy Whitcroft
2006-09-21 17:28   ` Andrew Morton
2006-09-21 18:02     ` Christoph Lameter
2006-09-21 18:07       ` Andy Whitcroft
2006-09-21 18:03     ` Andy Whitcroft
2006-09-21 13:40 ` 2.6.18-rc7-mm1 Ian Kent
2006-09-21 21:07 ` 2.6.18-rc7-mm1 Mark Haverkamp
2006-09-21 22:19   ` 2.6.18-rc7-mm1 Arnd Bergmann
2006-09-22 11:47 ` [PATCH -mm] x86_64 mm generic getcpu syscall fix Cedric Le Goater
2006-09-22 12:19   ` Andi Kleen
2006-09-23 11:03 ` 2.6.18-rc7-mm1 - gregkh-driver-pcmcia-device.patch breaks orinoco card Valdis.Kletnieks
2006-09-27  3:29   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060919173902.GB751@slug \
    --to=deweerdt@free.fr \
    --cc=akpm@osdl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox