Re: [PATCH] forcedeth: hardirq lockdep warning

Peter Zijlstra
2006-09-19T19:12:25Z

On Tue, 2006-09-19 at 11:14 -0700, Andrew Morton wrote:
> On Tue, 19 Sep 2006 14:55:22 +0200
> Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
>
> > BUG: warning at kernel/lockdep.c:1816/trace_hardirqs_on() (Not tainted)
>
> I wonder what line that was. DEBUG_LOCKS_WARN_ON(current->hardirq_context),
> I suppose.

Correct indeed.

> > Call Trace:
> > show_trace
> > dump_stack
> > trace_hardirqs_on
> > :forcedeth:nv_nic_irq_other
> > handle_IRQ_event
> > __do_IRQ
> > do_IRQ
> > ret_from_intr
> > DWARF2 barf
>
> It's good, isn't it?

Yeah, I hope we'll get it sorted out quickly....

> > default_idle
> > cpu_idle
> > rest_init
> > start_kernel
> > _sinittext
> >
> > These 3 functions nv_nic_irq_tx(), nv_nic_irq_rx() and nv_nic_irq_other()
> > are reachable from IRQ context and process context.
>
> That's "fix deadlock", not "fix lockdep warning". However it's often the
> case that it's not really deadlockable because (often) the card's IRQ line
> has been disabled. That appears to be the case in nv_do_nic_poll()'s call
> to nv_nic_irq_tx, for example.

Yeah, I saw some of that. But I'm not well versed in the various netdev
irq receive paths nor in the driver. I couldn't find the actual
maintainer in the MAINTAINERS file nor in the source, thanks for
including him in the CC. Lets hope he can say if this is an actual fix
or just a workaround.