From: Andrew Morton <akpm@osdl.org>
To: Alex Dubov <oakad@yahoo.com>
Cc: linux-kernel@vger.kernel.org, drzeus-list@drzeus.cx,
rmk+lkml@arm.linux.org.uk
Subject: Re: [PATCH 1/2] [MMC] Driver for TI FlashMedia card reader - source
Date: Tue, 19 Sep 2006 23:20:16 -0700 [thread overview]
Message-ID: <20060919232016.68a02e0e.akpm@osdl.org> (raw)
In-Reply-To: <20060920060212.7327.qmail@web36712.mail.mud.yahoo.com>
On Tue, 19 Sep 2006 23:02:11 -0700 (PDT)
Alex Dubov <oakad@yahoo.com> wrote:
> Driver for TI Flash Media card reader. At present, only MMC/SD
> cards are supported.
Could I ask where the information which permitted this (nice-looking) driver to
be written came from?
Trivia:
There's some whitespace damage in there. Please search the diff for "^ "
and fix it up.
We indent the body of switch statements one tab stop less than this driver
does.
The driver has lots of really big inlined functions. It's best to uninline
these. If the function has a single callsite, gcc will inline it anyway.
If the function has multiple callsites (now, or in the future), inlining it
is undesirable.
The driver has a lot of things like
static inline void* tifm_get_drvdata(struct tifm_dev *dev)
whereas we prefer
static inline void *tifm_get_drvdata(struct tifm_dev *dev)
next prev parent reply other threads:[~2006-09-20 6:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-20 6:02 [PATCH 1/2] [MMC] Driver for TI FlashMedia card reader - source Alex Dubov
2006-09-20 6:20 ` Andrew Morton [this message]
2006-09-20 6:28 ` Pekka Enberg
2006-09-20 16:36 ` Dave Jones
2006-09-21 5:15 ` Alexey Dobriyan
2006-09-21 2:51 ` Alex Dubov
2006-09-22 6:24 ` [PATCH 1/2 try 2] " Alex Dubov
2006-09-20 6:22 ` [PATCH 1/2] " Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060919232016.68a02e0e.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=oakad@yahoo.com \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox