From: Dave Jones <davej@redhat.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Andrew Morton <akpm@osdl.org>, Alex Dubov <oakad@yahoo.com>,
linux-kernel@vger.kernel.org, drzeus-list@drzeus.cx,
rmk+lkml@arm.linux.org.uk
Subject: Re: [PATCH 1/2] [MMC] Driver for TI FlashMedia card reader - source
Date: Wed, 20 Sep 2006 12:36:52 -0400 [thread overview]
Message-ID: <20060920163652.GF30550@redhat.com> (raw)
In-Reply-To: <84144f020609192328k4a2b2a70w5b068f49649398d6@mail.gmail.com>
On Wed, Sep 20, 2006 at 09:28:05AM +0300, Pekka Enberg wrote:
> On 9/20/06, Andrew Morton <akpm@osdl.org> wrote:
> > Trivia:
>
> [snip]
>
> More trivia:
>
> - Unnecessary casts for void pointers
> - Assignment in if statement expression
also
+#include <linux/config.h>
+#include <linux/module.h>
+#include <linux/kernel.h>
Some unnecessary includes there. (config.h & kernel.h are auto-included)
Dave
next prev parent reply other threads:[~2006-09-20 16:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-20 6:02 [PATCH 1/2] [MMC] Driver for TI FlashMedia card reader - source Alex Dubov
2006-09-20 6:20 ` Andrew Morton
2006-09-20 6:28 ` Pekka Enberg
2006-09-20 16:36 ` Dave Jones [this message]
2006-09-21 5:15 ` Alexey Dobriyan
2006-09-21 2:51 ` Alex Dubov
2006-09-22 6:24 ` [PATCH 1/2 try 2] " Alex Dubov
2006-09-20 6:22 ` [PATCH 1/2] " Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060920163652.GF30550@redhat.com \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=oakad@yahoo.com \
--cc=penberg@cs.helsinki.fi \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox