Re: [PATCH] move put_task_struct() reaping into a thread [Re: 2.6.18-rt1]

Ingo Molnar
2006-09-27T14:15:07Z

* Eric W. Biederman <ebiederm@xmission.com> wrote:

> I'm still wondering if we can move put_task_struct a little lower in
> the logic in the places where it is called, so it isn't called under a
> lock, or with preemption disabled. The only downside I see is that it
> might convolute the logic into unreadability.

well it's all a function of the task reaping logic: right now we in
essence complete the reaping from the scheduler, via prev_state ==
TASK_DEAD. We cannot do it sooner because the task is still in use. I
had one other implementation upstream some time ago, which was a
single-slot cache for reaped tasks - but that uglified other codepaths
because _something_ has to notice that the task has been unscheduled.

Ingo