Re: USB: u132-hcd: host controller driver for ELAN U132 adapter

[Greg KH <greg@kroah.com>]

On Wed, Sep 13, 2006 at 11:27:35AM +0100, Tony Olech wrote:
> This "u132-hcd" module is one half of the "driver" for
> ELAN's U132 which is a USB to CardBus OHCI controller
> adapter. This module needs the "ftdi-elan" module in
> order to communicate to CardBus OHCI controller inserted
> into the U132 adapter.
> 
> When the "ftdi-elan" module detects a supported CardBus
> OHCI controller in the U132 adapter it loads this "u132-hcd"
> module.
> 
> Upon a successful device probe() the single workqueue
> is started up which does all the processing of commands
> from the USB core that implement the host controller.
> 
> The workqueue maintains the urb queues and issues commands
> via the functions exported by the "ftdi-elan" module. Each
> such command will result in a callback.
> 
> Note that the "ftdi-elan" module is a USB client driver.
> 
> Note that this "u132-hcd" module is a (cut-down OHCI)
> host controller.
> 
> Thus we have a topology with the parent of a host controller
> being a USB client! This really stresses the USB subsystem
> semaphore/mutex handling in the module removal.
> 
> Signed-off-by: Tony Olech <tony.olech@elandigitalsystems.com>

I've applied this, and fixed up the build issue (needed to add it also
to the drivers/usb/Makefile file) and the sparse errors, but I'm still
getting these warnings:

drivers/usb/host/ohci.h:605: warning: 'periodic_reinit' defined but not used
drivers/usb/host/ohci.h:629: warning: 'roothub_a' defined but not used
drivers/usb/host/ohci.h:635: warning: 'roothub_portstatus' defined but not used

Care to send me a follow-on patch that fixes this?

thanks,

greg k-h