Re: [PATCH -mm 3/6] swsusp: Use block device offsets to identify swap locations

Rafael J. Wysocki
2006-09-21T22:18:34Z

On Thursday, 21 September 2006 23:30, Pavel Machek wrote:
> Hi!
>
> > Make swsusp use block device offsets instead of swap offsets to identify swap
> > locations and make it use the same code paths for writing as well as for
> > reading data.
> >
> > This allows us to use the same code for handling swap files and swap
> > partitions and to simplify the code, eg. by dropping rw_swap_page_sync().
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
>
> ACK. You may want to fix the comments, but that's probably separate
> patch.
>
>
> > Index: linux-2.6.18-rc7-mm1/mm/swapfile.c
> > ===================================================================
> > --- linux-2.6.18-rc7-mm1.orig/mm/swapfile.c
> > +++ linux-2.6.18-rc7-mm1/mm/swapfile.c
> > @@ -945,6 +945,23 @@ sector_t map_swap_page(struct swap_info_
> > }
> > }
> >
> > +#ifdef CONFIG_SOFTWARE_SUSPEND
> > +/*
> > + * Get the (PAGE_SIZE) block corrsponding to given offset on the swapdev
>
> corresponding?
>
> > + * corrsponding to given index in swap_info (swap type).
>
> here too...

Ouch, thanks.

I think I'll repost the whole series if Andrew doesn't pick it up, because
I made a typo in the name of the first patch (shame, shame).

Greetings,
Rafael

--
You never change things by fighting the existing reality.
R. Buckminster Fuller