Re: [PATCH -mm 0/6] swsusp: Add support for swap files

Nigel Cunningham
2006-09-23T23:24:21Z

Hi.

On Sun, 2006-09-24 at 00:59 +0200, Pavel Machek wrote:
> Hi!
>
> > > > > We could use a regular (non-swap) file like this but that would require us to
> > > > > use some dangerous code (ie. one that writes directly to blocks belonging to
> > > > > certain file bypassing the filesystem). IMHO this isn't worth it, provided
> > > > > the kernel's swap-handling code can do this for us and is known to work. ;-)
> > > >
> > > > It's not that dangerous once you debug it.
> > >
> > > Certainly. Still, let me repeat: if there is some code that does pretty much
> > > the same and has _already_ been debugged, I prefer using it to writing some
> > > new code, debugging it etc.
> >
> > Look at Suspend2 then. I know you won't want it in exactly that form,
> > but it's there and have been tested and debugged.
>
> Well, but any testing/debugging would have to be invalidated for a
> merge, sorry. suspend2 has diverged too much.
>
> "normal files" are not big priority for us, and you could probably do
> them in userland just now.... Anyway, diff -u for kernel or preferably
> for uswsusp parts would be welcome.
>
> Telling us how much suspend2 rocks with each and every mail... is not
> that welcome.

That's not what I was doing. I was saying that Rafael could, if he
wanted, at least look at how Suspend2 has done it and use that (if he
thinks its helpful) as a basis for improving or whatever. If he does
essentially the same thing for swsusp, he could again look at suspend2
loops etc to help in double checking his algorithm and so on.

Regards,

Nigel