Re: [PATCH -mm 0/6] swsusp: Add support for swap files

Rafael J. Wysocki
2006-09-22T11:26:04Z

On Friday, 22 September 2006 07:23, Pavel Machek wrote:
> On Fri 2006-09-22 11:01:53, Nigel Cunningham wrote:
> > Hi.
> >
> > On Wed, 2006-09-20 at 21:20 +0200, Rafael J. Wysocki wrote:
> > > Hi,
> > >
> > > The following series of patches makes swsusp support swap files.
> > >
> > > For now, it is only possible to suspend to a swap file using the in-kernel
> > > swsusp and the resume cannot be initiated from an initrd.
> >
> > I'm trying to understand 'resume cannot be initiated from an initrd'.
> > Does that mean if you want to use this functionality, you have to have
> > everything needed compiled in to the kernel, and it's not compatible
> > with LVM and so on?
>
> Not in this version of patch; for resume from initrd, ioctl()
> interface needs to be added (*).

Yup. This is not technically impossible, but the patches don't add an
interface needed for this purpose.

Initially I thought of a sysfs-based one, but it didn't seem to be a good
solution. I'm going to add an ioctl() to /dev/snapshot that will allow us
to set the "resume offset" from an application.

> Pavel
> (*) Actually.. of course resume from file from initrd is possible
> *now*, probably without this patch series, but that would be bmap and
> doing it by hand from userland.

Well, not from a swap file. To use a swap file for suspending we need a
kernel to tell us which page "slots" are available to us (otherwise we could
overwrite some swapped-out pages).

We could use a regular (non-swap) file like this but that would require us to
use some dangerous code (ie. one that writes directly to blocks belonging to
certain file bypassing the filesystem). IMHO this isn't worth it, provided
the kernel's swap-handling code can do this for us and is known to work. ;-)

Greetings,
Rafael

--
You never change things by fighting the existing reality.
R. Buckminster Fuller