Re: [PATCH -mm 4/6] swsusp: Add resume_offset command line parameter

Pavel Machek
2006-09-22T13:34:25Z

Hi!

> > > Add the kernel command line parameter "resume_offset=" allowing us to specify
> > > the offset, in <PAGE_SIZE> units, from the beginning of the partition pointed
> > > to by the "resume=" parameter at which the swap header is located.
> > >
> > > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> >
> > Okay, I'd prefer not to add aditional features to in-kernel swsusp,
> > but this is just not big enough to reject.
> >
> > ACK.
> >
> > (What is the solution for uswsusp?)
>
> We need an additional ioctl to set both the swap partition and "resume offset"
> at a time (the one we currently have allows us only to set the partition and I
> don't want to change it because of the backwards compatibility, but I think
> I'll change its name ;-) ).
>
> I'd like to add this ioctl along with the one needed to support the "platform"
> method of powering off, because it will require some similar documentation
> changes (most importantly, the description of the interface in
> Documentation/ABI which I'd like to add once and not to tamper with
> afterwards).

Ok, agreed.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html