Re: [PATCH -mm 3/6] swsusp: Use block device offsets to identify swap locations

Pavel Machek
2006-09-21T21:30:25Z

Hi!

> Make swsusp use block device offsets instead of swap offsets to identify swap
> locations and make it use the same code paths for writing as well as for
> reading data.
>
> This allows us to use the same code for handling swap files and swap
> partitions and to simplify the code, eg. by dropping rw_swap_page_sync().
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

ACK. You may want to fix the comments, but that's probably separate
patch.

> Index: linux-2.6.18-rc7-mm1/mm/swapfile.c
> ===================================================================
> --- linux-2.6.18-rc7-mm1.orig/mm/swapfile.c
> +++ linux-2.6.18-rc7-mm1/mm/swapfile.c
> @@ -945,6 +945,23 @@ sector_t map_swap_page(struct swap_info_
> }
> }
>
> +#ifdef CONFIG_SOFTWARE_SUSPEND
> +/*
> + * Get the (PAGE_SIZE) block corrsponding to given offset on the swapdev

corresponding?

> + * corrsponding to given index in swap_info (swap type).

here too...

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html