public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dtor@insightbb.com>
To: Robin Getz <rgetz@blackfin.uclinux.org>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>,
	linux-kernel@vger.kernel.org, Greg KH <gregkh@suse.de>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: drivers/char/random.c exported interfaces
Date: Thu, 21 Sep 2006 00:11:25 -0400	[thread overview]
Message-ID: <200609210011.25891.dtor@insightbb.com> (raw)
In-Reply-To: <6.1.1.1.0.20060920125855.01eca0c0@ptg1.spd.analog.com>

On Wednesday 20 September 2006 13:04, Robin Getz wrote:
> Randy Dunlap said:
> >ISTM that we should at least fix the first 2 (by EXPORTing them).
> >or we don't allow INPUT=m.
> >
> >You want to send a patch?
> 
> No problem - which patch do you want? (exporting? or set INPUT to bool?)
> 
> I'll send the export later tonight if no objections.
>

Would there be any objections if I commit the patch below so input
could be built as a module? 

-- 
Dmitry

Input: fix building input core as a module

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---

 drivers/char/random.c |    1 +
 lib/kobject.c         |    1 +
 2 files changed, 2 insertions(+)

Index: work/drivers/char/random.c
===================================================================
--- work.orig/drivers/char/random.c
+++ work/drivers/char/random.c
@@ -645,6 +645,7 @@ void add_input_randomness(unsigned int t
 	add_timer_randomness(&input_timer_state,
 			     (type << 4) ^ code ^ (code >> 4) ^ value);
 }
+EXPORT_SYMBOL_GPL(add_input_randomness);
 
 void add_interrupt_randomness(int irq)
 {
Index: work/lib/kobject.c
===================================================================
--- work.orig/lib/kobject.c
+++ work/lib/kobject.c
@@ -119,6 +119,7 @@ char *kobject_get_path(struct kobject *k
 
 	return path;
 }
+EXPORT_SYMBOL_GPL(kobject_get_path);
 
 /**
  *	kobject_init - initialize object.

  parent reply	other threads:[~2006-09-21  4:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-20 17:04 drivers/char/random.c exported interfaces Robin Getz
2006-09-20 17:20 ` Randy.Dunlap
2006-09-21  4:11 ` Dmitry Torokhov [this message]
2006-09-21 10:45   ` Theodore Tso
2006-09-21 11:30   ` Greg KH
2006-09-21 19:15   ` Dave Jones
     [not found]     ` <d120d5000609211238t1fb38d4exaa5c107a55a9eac3@mail.gmail.com>
2006-09-21 19:50       ` Dave Jones
  -- strict thread matches above, loose matches on Subject: below --
2006-09-21 20:35 Robin Getz
2006-09-18 13:27 Robin Getz
2006-09-20 16:56 ` Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200609210011.25891.dtor@insightbb.com \
    --to=dtor@insightbb.com \
    --cc=akpm@osdl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=rgetz@blackfin.uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox