public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Dmitry Torokhov <dtor@insightbb.com>,
	Robin Getz <rgetz@blackfin.uclinux.org>,
	"Randy.Dunlap" <rdunlap@xenotime.net>,
	linux-kernel@vger.kernel.org, Greg KH <gregkh@suse.de>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: drivers/char/random.c exported interfaces
Date: Thu, 21 Sep 2006 15:50:24 -0400	[thread overview]
Message-ID: <20060921195024.GI17065@redhat.com> (raw)
In-Reply-To: <d120d5000609211238t1fb38d4exaa5c107a55a9eac3@mail.gmail.com>

On Thu, Sep 21, 2006 at 03:38:56PM -0400, Dmitry Torokhov wrote:

 > > Under what circumstances is it desirable to allow INPUT=m ?
 > > I'm having a hard time thinking of a usage scenario where it makes sense.
 > 
 > Not normally, no. But for example NSLU2 has a beeper and I believe it
 > is the only user of input core there. If you were doing a distribution
 > for such device you might want to build both input core and speaker
 > driver as modules and let user decide if he wants to thoad them or
 > not.

Wow. That's a ton of code to be pulling in just to enable a beeper.
I wonder how many lines a non-input-layer variant of pcspkr.c would be.
It always seemed odd to me that a beeper is an input device anyway.

 > Does it being a module hurt anything?

Addition of two more exports for an arguably questionable purpose.

	Dave

  parent reply	other threads:[~2006-09-21 19:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-20 17:04 drivers/char/random.c exported interfaces Robin Getz
2006-09-20 17:20 ` Randy.Dunlap
2006-09-21  4:11 ` Dmitry Torokhov
2006-09-21 10:45   ` Theodore Tso
2006-09-21 11:30   ` Greg KH
2006-09-21 19:15   ` Dave Jones
     [not found]     ` <d120d5000609211238t1fb38d4exaa5c107a55a9eac3@mail.gmail.com>
2006-09-21 19:50       ` Dave Jones [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-09-21 20:35 Robin Getz
2006-09-18 13:27 Robin Getz
2006-09-20 16:56 ` Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060921195024.GI17065@redhat.com \
    --to=davej@redhat.com \
    --cc=akpm@osdl.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dtor@insightbb.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=rgetz@blackfin.uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox