From: David Chinner <dgc@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH -mm] rescue large xfs preferred iosize from the inode diet patch
Date: Fri, 22 Sep 2006 11:03:16 +1000 [thread overview]
Message-ID: <20060922010316.GY3034@melbourne.sgi.com> (raw)
In-Reply-To: <45131334.6050803@sandeen.net>
On Thu, Sep 21, 2006 at 05:33:24PM -0500, Eric Sandeen wrote:
> The inode diet patch in -mm unhooked xfs_preferred_iosize from the stat call:
....
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
>
> XFS guys, does this look ok?
>
> Index: linux-2.6.18/fs/xfs/linux-2.6/xfs_iops.c
> ===================================================================
> --- linux-2.6.18.orig/fs/xfs/linux-2.6/xfs_iops.c
> +++ linux-2.6.18/fs/xfs/linux-2.6/xfs_iops.c
> @@ -623,12 +623,16 @@ xfs_vn_getattr(
> {
> struct inode *inode = dentry->d_inode;
> bhv_vnode_t *vp = vn_from_inode(inode);
> + xfs_inode_t *ip;
> int error = 0;
>
> if (unlikely(vp->v_flag & VMODIFIED))
> error = vn_revalidate(vp);
> - if (!error)
> + if (!error) {
> generic_fillattr(inode, stat);
> + ip = xfs_vtoi(vp);
> + stat->blksize = xfs_preferred_iosize(ip->i_mount);
> + }
> return -error;
> }
ACK. Looks good, Eric. Good catch.
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2006-09-22 1:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-21 22:33 [PATCH -mm] rescue large xfs preferred iosize from the inode diet patch Eric Sandeen
2006-09-22 1:03 ` David Chinner [this message]
2006-09-22 2:03 ` Timothy Shimmin
2006-09-22 2:23 ` Eric Sandeen
2006-09-22 23:10 ` Andrew Morton
2006-09-22 23:19 ` Eric Sandeen
2006-09-22 23:34 ` Andrew Morton
2006-09-25 8:02 ` Timothy Shimmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060922010316.GY3034@melbourne.sgi.com \
--to=dgc@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox