From: Andi Kleen <ak@suse.de>
To: Dmitriy Zavin <dmitriyz@google.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH 4/4] therm_throt: Add a cumulative thermal throttle event counter.
Date: Fri, 22 Sep 2006 07:51:02 +0200 [thread overview]
Message-ID: <200609220751.02216.ak@suse.de> (raw)
In-Reply-To: <11588860852260-git-send-email-dmitriyz@google.com>
> + preempt_disable(); /* CPU hotplug */
> + for_each_online_cpu(cpu) {
> + /* connect live CPUs to sysfs */
> + thermal_throttle_add_dev(get_cpu_sysdev(cpu));
> + }
> + preempt_enable();
There was still one problem in there: sysfs_create_group can
sleep and that's not ok with preemption disabled.
I changed it to register the notifier first and do the necessary
locking in there using a private lock (that the new akpm-recommended(tm)
way to do this)
-Andi
next prev parent reply other threads:[~2006-09-22 5:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-22 0:48 [PATCH 0/4 v2] therm_throt: Refactor thermal throttle processing, and keep a total count of events Dmitriy Zavin
2006-09-22 0:48 ` [PATCH 1/4] x86_64/i386 therm mce: Refactor thermal throttle processing Dmitriy Zavin
2006-09-22 0:48 ` [PATCH 2/4] jiffies: Add 64bit jiffies compares (for use with get_jiffies_64) Dmitriy Zavin
2006-09-22 0:48 ` [PATCH 3/4] therm_throt: Make the jiffies compares use the 64bit safe macros Dmitriy Zavin
2006-09-22 0:48 ` [PATCH 4/4] therm_throt: Add a cumulative thermal throttle event counter Dmitriy Zavin
2006-09-22 5:51 ` Andi Kleen [this message]
2006-09-22 5:50 ` [PATCH 1/4] x86_64/i386 therm mce: Refactor thermal throttle processing Andi Kleen
2006-09-22 5:49 ` [PATCH 0/4 v2] therm_throt: Refactor thermal throttle processing, and keep a total count of events Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200609220751.02216.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=dmitriyz@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox