public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Ryan Moszynski <ryan.m.lists@gmail.com>
Cc: David Kubicek <dave@awk.cz>, linux-kernel@vger.kernel.org
Subject: Re: /drivers/usb/class/cdc-acm.c patch question, please cc
Date: Fri, 22 Sep 2006 15:30:47 -0700	[thread overview]
Message-ID: <20060922223047.GA21772@kroah.com> (raw)
In-Reply-To: <fbf7c10b0609221445q1329eb5bsfe304c02f7f336db@mail.gmail.com>

On Fri, Sep 22, 2006 at 05:45:21PM -0400, Ryan Moszynski wrote:
> using
> 2.6.18
> 
> quick version of this question:
> 
> how could i change line 1 to line 2 without breaking anything while
> providing the
> functionality of the patch i'm trying to apply?
> 
> 
> 	/* line 1  /drivers/usb/class/cdc-acm.c line 918
> 	readsize = le16_to_cpu(epread->wMaxPacketSize)* ( quirks ==
> SINGLE_RX_URB ? 1 : 2);
> 	
>        /* line 2
> 	readsize = (le16_to_cpu(epread->wMaxPacketSize) >
> maxszr)?le16_to_cpu(epread->wMaxPacketSize):maxszr;
> 
> 
> 
> 
> 
> long version:
> 
> since 2.6.14 i have been applying the following patch and recompiling
> my kernel so
> that i can use my verizon kpc650 evdo card with my laptop.  I've
> applied this patch
> succesfully on 2.6.14 and 2.6.15.  It works great and I have no problems.  
> I am
> trying to apply the patch to 2.6.18 but it fails, and i don't want to
> break anything,
> though I do need the functionality of the patch, since evdo is my only form 
> of
> internet(i live out in the sticks.) Without this patch, after setting
> up the needed
> config files, i can websurf, but if i try to download anything, the
> connection closes.
> 
> The rest of this patch, other than the chunk of which this line is a part,
> applies successfully.

Try the 2.6.18 kernel with no patch, it should have a driver for this
device already.

If not, let me know, and I'll work on something, you should not have to
modify the usb-serial core to get this device to actually use a sane
data rate.

thanks,

greg k-h

  reply	other threads:[~2006-09-22 22:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-22 21:45 /drivers/usb/class/cdc-acm.c patch question, please cc Ryan Moszynski
2006-09-22 22:30 ` Greg KH [this message]
2006-09-24 13:26 ` Oliver Neukum
2006-09-24 17:40   ` Ryan Moszynski
2006-09-25 15:07     ` Ryan Moszynski
2006-09-27  4:54     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060922223047.GA21772@kroah.com \
    --to=greg@kroah.com \
    --cc=dave@awk.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ryan.m.lists@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox