From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH]: Fix ALIGN() macro
Date: Sat, 23 Sep 2006 13:12:52 -0700 (PDT) [thread overview]
Message-ID: <20060923.131252.74747591.davem@davemloft.net> (raw)
In-Reply-To: <20060923144041.GA3540@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sun, 24 Sep 2006 00:40:41 +1000
> OK I think I've found the problem.
>
> [CRYPTO] hmac: Fix hmac_init update call
>
> The crypto_hash_update call in hmac_init gave the number 1
> instead of the length of the sg list in bytes. This is a
> missed conversion from the digest => hash change.
>
> As tcrypt only tests crypto_hash_digest it didn't catch this.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This, along with the ALIGN() patch, fixes all the regressions
for me. Good spotting Herbert!
Linus, please apply.
next prev parent reply other threads:[~2006-09-23 20:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-23 5:31 [PATCH]: Fix ALIGN() macro David Miller
2006-09-23 12:46 ` Herbert Xu
2006-09-23 12:54 ` Herbert Xu
2006-09-23 14:40 ` Herbert Xu
2006-09-23 20:12 ` David Miller [this message]
2006-09-23 20:36 ` Kyle Moffett
2006-09-23 20:42 ` Kyle Moffett
2006-09-23 23:30 ` Herbert Xu
2006-09-23 19:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060923.131252.74747591.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox