From: Sam Ravnborg <sam@ravnborg.org>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Linus Torvalds <torvalds@osdl.org>,
rolandd@cisco.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] missing includes from infiniband merge
Date: Sat, 23 Sep 2006 22:29:12 +0200 [thread overview]
Message-ID: <20060923202912.GA22293@uranus.ravnborg.org> (raw)
In-Reply-To: <20060923154416.GH29920@ftp.linux.org.uk>
On Sat, Sep 23, 2006 at 04:44:16PM +0100, Al Viro wrote:
> indirect chains of includes are arch-specific and can't
> be relied upon... (hell, even attempt to build it for
> itanic would trigger vmalloc.h ones; err.h triggers
> on e.g. alpha).
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> drivers/infiniband/core/mad_priv.h | 1 +
> drivers/infiniband/hw/amso1100/c2_provider.c | 1 +
> drivers/infiniband/hw/amso1100/c2_rnic.c | 1 +
> drivers/infiniband/hw/ipath/ipath_diag.c | 1 +
> 4 files changed, 4 insertions(+), 0 deletions(-)
A better fix would be to avoid the arch dependency in the non-arch .h
files so that in most cases it just works??
That will result in a few files being included twice or more but
does that matter with current gcc - I doubt.
Sam
next prev parent reply other threads:[~2006-09-23 20:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-23 15:44 [PATCH] missing includes from infiniband merge Al Viro
2006-09-23 17:35 ` Roland Dreier
2006-09-23 20:29 ` Sam Ravnborg [this message]
2006-09-23 20:36 ` Al Viro
2006-09-23 20:54 ` Al Viro
2006-09-24 6:44 ` Sam Ravnborg
2006-09-24 19:19 ` Al Viro
2006-09-24 20:52 ` Sam Ravnborg
2006-09-24 21:35 ` Al Viro
2006-09-24 21:56 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060923202912.GA22293@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rolandd@cisco.com \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox