public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: Hugh Dickins <hugh@veritas.com>
Cc: Anatoli Antonovitch <antonovi@ati.com>,
	Tigran Aivazian <tigran@veritas.com>,
	Michael Chen <micche@ati.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH]i386: fix overflow in vmap on an x86 system which has more than 4GB memory.
Date: Sun, 24 Sep 2006 01:55:33 +0200	[thread overview]
Message-ID: <20060923235533.GC24214@1wt.eu> (raw)
In-Reply-To: <Pine.LNX.4.64.0609231759590.30885@blonde.wat.veritas.com>

Hi Hugh !

On Sat, Sep 23, 2006 at 06:26:26PM +0100, Hugh Dickins wrote:
> This is a 2.4 fix (not needed in 2.6): let's CC maintainer Willy Tarreau.
> 
> On Fri, 15 Sep 2006, Anatoli Antonovitch wrote:
> 
> > Description
> > (max_mapnr << PAGE_SHIFT) would overflow on an x86 system which has more
> > than 4GB memory, and hence cause vmap to fail every time.
> 
> Good point, thanks for the patch.  Sorry I'm so slow to get to it.

Don't worry, Andrew already forwarded it to me. BTW, thanks for your
review and comment, I'll finally apply yours since it's better.

Cheers,
Willy


      reply	other threads:[~2006-09-24  0:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-15 15:34 [PATCH]i386: fix overflow in vmap on an x86 system which has more than 4GB memory Anatoli Antonovitch
2006-09-23 17:26 ` Hugh Dickins
2006-09-23 23:55   ` Willy Tarreau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060923235533.GC24214@1wt.eu \
    --to=w@1wt.eu \
    --cc=antonovi@ati.com \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=micche@ati.com \
    --cc=tigran@veritas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox