From: David Miller <davem@davemloft.net>
To: mostrows@earthlink.net
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
ppp-bugs@dp.samba.org
Subject: Re: [PATCH] Advertise PPPoE MTU / avoid memory leak.
Date: Sun, 24 Sep 2006 18:41:18 -0700 (PDT) [thread overview]
Message-ID: <20060924.184118.104036249.davem@davemloft.net> (raw)
In-Reply-To: <1159100966.23197.293.camel@brick.austin.ibm.com>
From: Michal Ostrowski <mostrows@earthlink.net>
Date: Sun, 24 Sep 2006 07:29:25 -0500
> I think the call path via dev->hard_start_xmit, if it fails, may result
> in an skb not being freed. This appears to be the case with the e100.c
> driver. The qdisc_restart path to dev->hard_start_xmit also appears
> susceptible to this. It appears that not all devices agree as to who
> should clean-up an skb on error.
There is a well defined policy about who frees the SKB or has
ownership of it based upon dev->hard_start_xmit() return values.
Any driver deviating from this set of rules should simply be
audited and fixed, as needed.
But, no matter, your change is buggy and we can't apply your
patch (even if it does fix a leak in some legitimate case)
because it introduces an obvious double-free bug.
next prev parent reply other threads:[~2006-09-25 1:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-23 17:30 [PATCH] Advertise PPPoE MTU / avoid memory leak mostrows
2006-09-23 21:56 ` David Miller
2006-09-24 12:29 ` Michal Ostrowski
2006-09-25 1:41 ` David Miller [this message]
2006-09-25 18:16 ` Michal Ostrowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060924.184118.104036249.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mostrows@earthlink.net \
--cc=netdev@vger.kernel.org \
--cc=ppp-bugs@dp.samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox