From: Paul Mundt <lethal@linux-sh.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Hirokazu Takata <takata@linux-m32r.org>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH] m32r: Revise __raw_read_trylock()
Date: Mon, 25 Sep 2006 15:09:17 +0900 [thread overview]
Message-ID: <20060925060917.GA8422@localhost.na.rta> (raw)
In-Reply-To: <20060922112708.GR2585@parisc-linux.org>
On Fri, Sep 22, 2006 at 05:27:08AM -0600, Matthew Wilcox wrote:
> You're assuming:
>
> - a spinlock is an atomic_t.
> - Said atomic_t uses RW_LOCK_BIAS to indicate locked/unlocked.
>
> This is true for m32r, but not for sparc.
That makes sense, thanks for the clarification.
> SuperH looks completely broken -- I don't see how holding a read lock
> prevents someone else from getting a write lock. The SH write_trylock
> uses RW_LOCK_BIAS, but write_lock doesn't. Are there any SMP SH
> machines?
Yes, it's broken, most of the work for that has been happening out of
tree, and we'll have to sync it up again. The initial work was targetted
at a pair of microcontrollers, but there were too many other issues
there that the work was eventually abandoned. Recently it's started up
again on more reasonable CPUs, so we'll be fixing these things up in
order.
next prev parent reply other threads:[~2006-09-25 6:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-22 6:29 [PATCH] m32r: Revise __raw_read_trylock() Hirokazu Takata
2006-09-22 7:48 ` Paul Mundt
2006-09-22 11:27 ` Matthew Wilcox
2006-09-25 6:09 ` Paul Mundt [this message]
2006-09-24 6:20 ` Matthew Wilcox
2006-09-25 7:47 ` Hirokazu Takata
2006-09-26 21:33 ` Andrew Morton
2006-09-26 22:29 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060925060917.GA8422@localhost.na.rta \
--to=lethal@linux-sh.org \
--cc=akpm@osdl.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=takata@linux-m32r.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox