From: Mike Anderson <andmike@us.ibm.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: "Hammer, Jack" <Jack_Hammer@adaptec.com>,
Al Viro <viro@ftp.linux.org.uk>, Luben Tuikov <ltuikov@yahoo.com>,
dougg@torque.net, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix idiocy in asd_init_lseq_mdp()
Date: Mon, 25 Sep 2006 11:29:38 -0700 [thread overview]
Message-ID: <20060925182938.GA4635@us.ibm.com> (raw)
In-Reply-To: <1159206202.3463.62.camel@mulgrave.il.steeleye.com>
James Bottomley <James.Bottomley@SteelEye.com> wrote:
> On Mon, 2006-09-25 at 18:39 +0100, Al Viro wrote:
> > Far more interesting question: where does the hardware expect to see
> > the
> > upper 16 bits of that 32bit value? Which one it is -
> > LmSEQ_INTEN_SAVE(lseq)
> > ori LmSEQ_INTEN_SAVE(lseq) + 2?
>
> I don't honestly know. The change was made as part of a slew of changes
> by Robert Tarte at Adaptec to make the driver run on Big Endian
> platforms. I've copied Jack Hammer who's now looking after it in the
> hope that he can enlighten us.
This was not Rob. I sent this bad code out in a roll up of support for
non-x86 systems (and bad process for not running sparse on the
patch which passed the buck onto someone else to find).
I think it might have been for an IA64 offset issue someone was seeing. I
cannot find the original mail on the issue in my mail archives.
I will try and track down a IA64 system to see if we can verify this is
really needed. If not we should revert back to the original dword
implementation.
-andmike
--
Michael Anderson
andmike@us.ibm.com
next prev parent reply other threads:[~2006-09-25 18:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-25 1:57 [PATCH] fix idiocy in asd_init_lseq_mdp() Al Viro
2006-09-25 6:52 ` Luben Tuikov
2006-09-25 6:54 ` Luben Tuikov
2006-09-25 14:47 ` Douglas Gilbert
2006-09-25 14:59 ` Al Viro
2006-09-25 17:16 ` Luben Tuikov
2006-09-25 17:39 ` Al Viro
2006-09-25 17:43 ` James Bottomley
2006-09-25 18:29 ` Mike Anderson [this message]
2006-09-25 19:14 ` Luben Tuikov
-- strict thread matches above, loose matches on Subject: below --
2006-09-25 19:56 Hammer, Jack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060925182938.GA4635@us.ibm.com \
--to=andmike@us.ibm.com \
--cc=Jack_Hammer@adaptec.com \
--cc=James.Bottomley@SteelEye.com \
--cc=dougg@torque.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ltuikov@yahoo.com \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox