public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 6/8] UML - Add checkstack support
@ 2006-09-25 18:34 Jeff Dike
  2006-09-25 18:58 ` Matt Mackall
  0 siblings, 1 reply; 3+ messages in thread
From: Jeff Dike @ 2006-09-25 18:34 UTC (permalink / raw)
  To: akpm
  Cc: linux-kernel, user-mode-linux-devel, Paolo Giarrusso,
	Matt Mackall, Joern Engel

Make checkstack work for UML.  We need to pass the underlying architecture
name, rather than "um" to checkstack.pl.

Signed-off-by: Jeff Dike <jdike@addtoit.com>

Index: linux-2.6.18-mm/Makefile
===================================================================
--- linux-2.6.18-mm.orig/Makefile	2006-09-22 11:34:57.000000000 -0400
+++ linux-2.6.18-mm/Makefile	2006-09-22 11:35:38.000000000 -0400
@@ -1333,9 +1333,13 @@ endif #ifeq ($(config-targets),1)
 endif #ifeq ($(mixed-targets),1)
 
 PHONY += checkstack kernelrelease kernelversion
+
+# Use $(SUBARCH) here instead of $(ARCH) so that this works for UML.
+# In the UML case, $(SUBARCH) is the name of the underlying
+# architecture, while for all other arches, it is the same as $(ARCH).
 checkstack:
 	$(OBJDUMP) -d vmlinux $$(find . -name '*.ko') | \
-	$(PERL) $(src)/scripts/checkstack.pl $(ARCH)
+	$(PERL) $(src)/scripts/checkstack.pl $(SUBARCH)
 
 kernelrelease:
 	$(if $(wildcard include/config/kernel.release), $(Q)echo $(KERNELRELEASE), \


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 6/8] UML - Add checkstack support
  2006-09-25 18:34 [PATCH 6/8] UML - Add checkstack support Jeff Dike
@ 2006-09-25 18:58 ` Matt Mackall
  2006-09-26  9:28   ` Jörn Engel
  0 siblings, 1 reply; 3+ messages in thread
From: Matt Mackall @ 2006-09-25 18:58 UTC (permalink / raw)
  To: Jeff Dike
  Cc: akpm, linux-kernel, user-mode-linux-devel, Paolo Giarrusso,
	Joern Engel

On Mon, Sep 25, 2006 at 02:34:41PM -0400, Jeff Dike wrote:
> Make checkstack work for UML.  We need to pass the underlying architecture
> name, rather than "um" to checkstack.pl.
> 
> Signed-off-by: Jeff Dike <jdike@addtoit.com>

Acked-by: Matt Mackall <mpm@selenic.com>

-- 
Mathematics is the supreme nostalgia of our time.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 6/8] UML - Add checkstack support
  2006-09-25 18:58 ` Matt Mackall
@ 2006-09-26  9:28   ` Jörn Engel
  0 siblings, 0 replies; 3+ messages in thread
From: Jörn Engel @ 2006-09-26  9:28 UTC (permalink / raw)
  To: Matt Mackall
  Cc: Jeff Dike, akpm, linux-kernel, user-mode-linux-devel,
	Paolo Giarrusso

On Mon, 25 September 2006 13:58:52 -0500, Matt Mackall wrote:
> On Mon, Sep 25, 2006 at 02:34:41PM -0400, Jeff Dike wrote:
> > Make checkstack work for UML.  We need to pass the underlying architecture
> > name, rather than "um" to checkstack.pl.
> > 
> > Signed-off-by: Jeff Dike <jdike@addtoit.com>
> 
> Acked-by: Matt Mackall <mpm@selenic.com>
Acked-by: Joern Engel <joern@wohnheim.fh-wedel.de>

Jörn

-- 
Homo Sapiens is a goal, not a description.
-- unknown

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2006-09-26  9:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-25 18:34 [PATCH 6/8] UML - Add checkstack support Jeff Dike
2006-09-25 18:58 ` Matt Mackall
2006-09-26  9:28   ` Jörn Engel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox