From: "J. Bruce Fields" <bfields@fieldses.org>
To: NeilBrown <neilb@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [NFS] [PATCH 009 of 11] knfsd: Allow max size of NFSd payload to be configured.
Date: Mon, 25 Sep 2006 17:24:57 -0400 [thread overview]
Message-ID: <20060925212457.GK32762@fieldses.org> (raw)
In-Reply-To: <1060824063716.5020@suse.de>
On Thu, Aug 24, 2006 at 04:37:16PM +1000, NeilBrown wrote:
> diff .prev/fs/nfsd/nfssvc.c ./fs/nfsd/nfssvc.c
> --- .prev/fs/nfsd/nfssvc.c 2006-08-24 16:26:10.000000000 +1000
> +++ ./fs/nfsd/nfssvc.c 2006-08-24 16:26:10.000000000 +1000
> @@ -198,9 +198,26 @@ int nfsd_create_serv(void)
> unlock_kernel();
> return 0;
> }
> + if (nfsd_max_blksize == 0) {
> + /* choose a suitable default */
> + struct sysinfo i;
> + si_meminfo(&i);
> + /* Aim for 1/4096 of memory per thread
> + * This gives 1MB on 4Gig machines
> + * But only uses 32K on 128M machines.
> + * Bottom out at 8K on 32M and smaller.
> + * Of course, this is only a default.
> + */
> + nfsd_max_blksize = NFSSVC_MAXBLKSIZE;
> + i.totalram >>= 12;
> + while (nfsd_max_blksize > i.totalram &&
> + nfsd_max_blksize >= 8*1024*2)
> + nfsd_max_blksize /= 2;
> + }
It looks to me like totalram is actually measured in pages. So in
practice this gives almost everyone 8k here. So that 12 should be
something like 12 - PAGE_CACHE_SHIFT?
--b.
next prev parent reply other threads:[~2006-09-25 21:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-24 6:36 [PATCH 000 of 11] knfsd: Introduction NeilBrown
2006-08-24 6:36 ` [PATCH 001 of 11] knfsd: nfsd: lockdep annotation fix NeilBrown
2006-08-24 6:36 ` [PATCH 002 of 11] knfsd: Fix a botched comment from the last patchset NeilBrown
2006-08-24 6:36 ` [PATCH 003 of 11] knfsd: call lockd_down when closing a socket via a write to nfsd/portlist NeilBrown
2006-08-24 6:36 ` [PATCH 004 of 11] knfsd: Protect update to sn_nrthreads with lock_kernel NeilBrown
2006-08-24 6:36 ` [PATCH 005 of 11] knfsd: Fixed handling of lockd fail when adding nfsd socket NeilBrown
2006-08-24 6:36 ` [PATCH 006 of 11] knfsd: Replace two page lists in struct svc_rqst with one NeilBrown
2006-08-24 6:37 ` [PATCH 007 of 11] knfsd: Avoid excess stack usage in svc_tcp_recvfrom NeilBrown
2006-08-24 6:37 ` [PATCH 008 of 11] knfsd: Prepare knfsd for support of rsize/wsize of up to 1MB, over TCP NeilBrown
2006-09-25 15:43 ` [NFS] " J. Bruce Fields
2006-09-28 3:41 ` Neil Brown
2006-09-28 3:46 ` Andrew Morton
2006-10-03 1:36 ` Neil Brown
2006-10-03 1:59 ` Greg Banks
2006-10-03 2:13 ` J. Bruce Fields
2006-10-03 5:41 ` Neil Brown
2006-10-03 8:02 ` Greg Banks
2006-10-05 7:07 ` Neil Brown
2006-08-24 6:37 ` [PATCH 009 of 11] knfsd: Allow max size of NFSd payload to be configured NeilBrown
2006-09-25 21:24 ` J. Bruce Fields [this message]
2006-09-28 4:22 ` [NFS] " Neil Brown
2006-09-28 17:09 ` Hugh Dickins
2006-09-29 1:59 ` Neil Brown
2006-08-24 6:37 ` [PATCH 010 of 11] knfsd: make nfsd readahead params cache SMP-friendly NeilBrown
2006-08-24 6:37 ` [PATCH 011 of 11] knfsd: knfsd: cache ipmap per TCP socket NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060925212457.GK32762@fieldses.org \
--to=bfields@fieldses.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox