From: Dmitry Torokhov <dtor@insightbb.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-kernel@vger.kernel.org, Jiri Kosina <jikos@jikos.cz>,
Andrew Morton <akpm@osdl.org>,
Arjan van de Ven <arjan@infradead.org>,
Dave Jones <davej@redhat.com>
Subject: Re: [PATCH 1/2] lockdep: lockdep_set_class_and_subclass
Date: Tue, 26 Sep 2006 08:20:57 -0400 [thread overview]
Message-ID: <200609260820.58837.dtor@insightbb.com> (raw)
In-Reply-To: <20060926115404.GA18283@elte.hu>
On Tuesday 26 September 2006 07:54, Ingo Molnar wrote:
>
> * Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
>
> > Add lockdep_set_class_and_subclass() to the lockdep annotations.
> >
> > This annotation makes it possible to assign a subclass on lock init.
> > This annotation is meant to reduce the _nested() annotations by
> > assigning a default subclass.
> >
> > One could do without this annotation and rely on lockdep_set_class()
> > exclusively, but that would require a manual stack of struct
> > lock_class_key objects.
> >
> > Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
>
> thanks, this extension to lockdep.c looks good to me - provided it
> solves the problem :-)
>
> Acked-by: Ingo Molnar <mingo@elte.hu>
>
I will try testing it tonight - I have a Synaptics with a pass-through
port. Anyway, it really looks good now as far as serio code concerned.
--
Dmitry
next prev parent reply other threads:[~2006-09-26 12:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-26 11:31 [PATCH 0/2] serio lockdep annotation Peter Zijlstra
2006-09-26 11:31 ` [PATCH 1/2] lockdep: lockdep_set_class_and_subclass Peter Zijlstra
2006-09-26 11:54 ` Ingo Molnar
2006-09-26 12:20 ` Dmitry Torokhov [this message]
2006-09-26 11:31 ` [PATCH 2/2] serio: lockdep annotation for ps2dev->cmd_mutex and serio->lock Peter Zijlstra
2006-09-26 13:21 ` Jiri Kosina
2006-09-26 13:36 ` Peter Zijlstra
2006-09-26 13:30 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200609260820.58837.dtor@insightbb.com \
--to=dtor@insightbb.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=davej@redhat.com \
--cc=jikos@jikos.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox