* pcie_portdrv_restore_config undefined without CONFIG_PM
@ 2006-09-27 19:42 Olaf Hering
2006-09-28 6:35 ` Zhang, Yanmin
0 siblings, 1 reply; 3+ messages in thread
From: Olaf Hering @ 2006-09-27 19:42 UTC (permalink / raw)
To: Zhang Yanmin, Greg Kroah-Hartman, linux-kernel
PCI-Express AER implemetation: pcie_portdrv error handler
This patch breaks if CONFIG_PM is not enabled,
pcie_portdrv_restore_config() will be undefined.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: pcie_portdrv_restore_config undefined without CONFIG_PM
2006-09-27 19:42 pcie_portdrv_restore_config undefined without CONFIG_PM Olaf Hering
@ 2006-09-28 6:35 ` Zhang, Yanmin
2006-09-28 6:47 ` Olaf Hering
0 siblings, 1 reply; 3+ messages in thread
From: Zhang, Yanmin @ 2006-09-28 6:35 UTC (permalink / raw)
To: Olaf Hering; +Cc: Yanmin Zhang, Greg Kroah-Hartman, LKML
On Thu, 2006-09-28 at 03:42, Olaf Hering wrote:
> PCI-Express AER implemetation: pcie_portdrv error handler
>
> This patch breaks if CONFIG_PM is not enabled,
> pcie_portdrv_restore_config() will be undefined.
I move the definition of pcie_portdrv_restore_config
out of CONFIG_PM.
Below patch is against 2.6.18-mm1. Could you try it?
Signed-off-by: Zhang Yanmin <yanmin.zhang@intel.com>
---
diff -Nraup linux-2.6.18_mm1/drivers/pci/pcie/portdrv_pci.c linux-2.6.18_mm1_fix/drivers/pci/pcie/portdrv_pci.c
--- linux-2.6.18_mm1/drivers/pci/pcie/portdrv_pci.c 2006-09-29 07:19:48.000000000 -0600
+++ linux-2.6.18_mm1_fix/drivers/pci/pcie/portdrv_pci.c 2006-09-29 07:21:08.000000000 -0600
@@ -37,7 +37,6 @@ static int pcie_portdrv_save_config(stru
return pci_save_state(dev);
}
-#ifdef CONFIG_PM
static int pcie_portdrv_restore_config(struct pci_dev *dev)
{
int retval;
@@ -50,6 +49,7 @@ static int pcie_portdrv_restore_config(s
return 0;
}
+#ifdef CONFIG_PM
static int pcie_portdrv_suspend(struct pci_dev *dev, pm_message_t state)
{
int ret = pcie_port_device_suspend(dev, state);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: pcie_portdrv_restore_config undefined without CONFIG_PM
2006-09-28 6:35 ` Zhang, Yanmin
@ 2006-09-28 6:47 ` Olaf Hering
0 siblings, 0 replies; 3+ messages in thread
From: Olaf Hering @ 2006-09-28 6:47 UTC (permalink / raw)
To: Zhang, Yanmin; +Cc: Yanmin Zhang, Greg Kroah-Hartman, LKML
On Thu, Sep 28, Zhang, Yanmin wrote:
> On Thu, 2006-09-28 at 03:42, Olaf Hering wrote:
> > PCI-Express AER implemetation: pcie_portdrv error handler
> >
> > This patch breaks if CONFIG_PM is not enabled,
> > pcie_portdrv_restore_config() will be undefined.
> I move the definition of pcie_portdrv_restore_config
> out of CONFIG_PM.
>
> Below patch is against 2.6.18-mm1. Could you try it?
This fixes arch/powerpc/configs/cell_defconfig. Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-09-28 6:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-27 19:42 pcie_portdrv_restore_config undefined without CONFIG_PM Olaf Hering
2006-09-28 6:35 ` Zhang, Yanmin
2006-09-28 6:47 ` Olaf Hering
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox