From: Olaf Hering <olaf@aepfle.de>
To: sam@ravnborg.org, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] add XARGS to toplevel Makefile
Date: Thu, 28 Sep 2006 08:02:24 +0200 [thread overview]
Message-ID: <20060928060224.GA16290@aepfle.de> (raw)
run xargs with --no-run-if-empty to avoid random failures:
MAKE tags
ctags: No files specified. Try "ctags --help".
make: *** [tags] Error 123
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
Makefile | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
Index: linux-2.6/Makefile
===================================================================
--- linux-2.6.orig/Makefile
+++ linux-2.6/Makefile
@@ -295,6 +295,7 @@ DEPMOD = /sbin/depmod
KALLSYMS = scripts/kallsyms
PERL = perl
CHECK = sparse
+XARGS = xargs --no-run-if-empty
CHECKFLAGS := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ -Wbitwise $(CF)
MODFLAGS = -DMODULE
@@ -1049,7 +1050,7 @@ clean: archclean $(clean-dirs)
\( -name '*.[oas]' -o -name '*.ko' -o -name '.*.cmd' \
-o -name '.*.d' -o -name '.*.tmp' -o -name '*.mod.c' \
-o -name '*.symtypes' \) \
- -type f -print | xargs rm -f
+ -type f -print | $(XARGS) rm -f
# mrproper - Delete all generated files, including .config
#
@@ -1075,7 +1076,7 @@ distclean: mrproper
-o -name '*.bak' -o -name '#*#' -o -name '.*.orig' \
-o -name '.*.rej' -o -size 0 \
-o -name '*%' -o -name '.*.cmd' -o -name 'core' \) \
- -type f -print | xargs rm -f
+ -type f -print | $(XARGS) rm -f
# Packaging of the kernel to various formats
@@ -1237,7 +1238,7 @@ clean: $(clean-dirs)
@find $(KBUILD_EXTMOD) $(RCS_FIND_IGNORE) \
\( -name '*.[oas]' -o -name '*.ko' -o -name '.*.cmd' \
-o -name '.*.d' -o -name '.*.tmp' -o -name '*.mod.c' \) \
- -type f -print | xargs rm -f
+ -type f -print | $(XARGS) rm -f
help:
@echo ' Building external modules.'
@@ -1313,26 +1314,26 @@ endef
define xtags
if $1 --version 2>&1 | grep -iq exuberant; then \
- $(all-sources) | xargs $1 -a \
+ $(all-sources) | $(XARGS) $1 -a \
-I __initdata,__exitdata,__acquires,__releases \
-I EXPORT_SYMBOL,EXPORT_SYMBOL_GPL \
--extra=+f --c-kinds=+px; \
- $(all-kconfigs) | xargs $1 -a \
+ $(all-kconfigs) | $(XARGS) $1 -a \
--langdef=kconfig \
--language-force=kconfig \
--regex-kconfig='/^[[:blank:]]*config[[:blank:]]+([[:alnum:]_]+)/\1/'; \
- $(all-defconfigs) | xargs $1 -a \
+ $(all-defconfigs) | $(XARGS) $1 -a \
--langdef=dotconfig \
--language-force=dotconfig \
--regex-dotconfig='/^#?[[:blank:]]*(CONFIG_[[:alnum:]_]+)/\1/'; \
elif $1 --version 2>&1 | grep -iq emacs; then \
- $(all-sources) | xargs $1 -a; \
- $(all-kconfigs) | xargs $1 -a \
+ $(all-sources) | $(XARGS) $1 -a; \
+ $(all-kconfigs) | $(XARGS) $1 -a \
--regex='/^[ \t]*config[ \t]+\([a-zA-Z0-9_]+\)/\1/'; \
- $(all-defconfigs) | xargs $1 -a \
+ $(all-defconfigs) | $(XARGS) $1 -a \
--regex='/^#?[ \t]?\(CONFIG_[a-zA-Z0-9_]+\)/\1/'; \
else \
- $(all-sources) | xargs $1 -a; \
+ $(all-sources) | $(XARGS) $1 -a; \
fi
endef
@@ -1371,12 +1372,12 @@ tags: FORCE
includecheck:
find * $(RCS_FIND_IGNORE) \
-name '*.[hcS]' -type f -print | sort \
- | xargs $(PERL) -w scripts/checkincludes.pl
+ | $(XARGS) $(PERL) -w scripts/checkincludes.pl
versioncheck:
find * $(RCS_FIND_IGNORE) \
-name '*.[hcS]' -type f -print | sort \
- | xargs $(PERL) -w scripts/checkversion.pl
+ | $(XARGS) $(PERL) -w scripts/checkversion.pl
namespacecheck:
$(PERL) $(srctree)/scripts/namespace.pl
next reply other threads:[~2006-09-28 6:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 6:02 Olaf Hering [this message]
2006-09-28 8:33 ` [PATCH] add XARGS to toplevel Makefile Jan Engelhardt
2006-09-28 10:21 ` Sam Ravnborg
2006-09-28 10:55 ` Segher Boessenkool
2006-09-30 7:54 ` Olaf Hering
2006-09-30 8:05 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060928060224.GA16290@aepfle.de \
--to=olaf@aepfle.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox