From: Paul Jackson <pj@sgi.com>
To: menage@google.com
Cc: akpm@osdl.org, ckrm-tech@lists.sourceforge.net,
mbligh@google.com, rohitseth@google.com, winget@google.com,
dev@sw.ru, sekharan@us.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 2/4] Cpusets hooked into containers
Date: Thu, 28 Sep 2006 16:48:08 -0700 [thread overview]
Message-ID: <20060928164808.87a9fa18.pj@sgi.com> (raw)
In-Reply-To: <20060928111408.095816000@menage.corp.google.com>
Menage wrote:
> +#ifdef CONFIG_CPUSETS
> + err = cpuset_create(cont);
> + if (err) goto err_unlock_free;
> +#endif
I believe recommended kernel style puts the if() statement
on a separate line, as in:
+#ifdef CONFIG_CPUSETS
+ err = cpuset_create(cont);
+ if (err)
+ goto err_unlock_free;
+#endif
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
next prev parent reply other threads:[~2006-09-28 23:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 10:40 [RFC][PATCH 0/4] Generic container system menage
2006-09-28 10:40 ` [RFC][PATCH 1/4] Generic container system abstracted from cpusets code menage
2006-09-28 23:45 ` Paul Jackson
2006-10-02 6:48 ` Paul Menage
2006-10-02 8:46 ` [ckrm-tech] " Paul Jackson
2006-10-02 8:48 ` Paul Jackson
2006-09-28 10:40 ` [RFC][PATCH 2/4] Cpusets hooked into containers menage
2006-09-28 23:48 ` Paul Jackson [this message]
2006-09-28 10:40 ` [RFC][PATCH 3/4] Add generic multi-subsystem API to containers menage
2006-09-28 10:40 ` [RFC][PATCH 4/4] Simple CPU accounting container subsystem menage
2006-09-28 18:49 ` [RFC][PATCH 0/4] Generic container system Paul Jackson
2006-09-28 19:00 ` Paul Menage
2006-09-29 4:31 ` Paul Jackson
2006-09-29 15:43 ` [ckrm-tech] " Paul Menage
-- strict thread matches above, loose matches on Subject: below --
2006-10-02 9:53 Paul Menage
2006-10-02 9:53 ` [RFC][PATCH 2/4] Cpusets hooked into containers Paul Menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060928164808.87a9fa18.pj@sgi.com \
--to=pj@sgi.com \
--cc=akpm@osdl.org \
--cc=ckrm-tech@lists.sourceforge.net \
--cc=dev@sw.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@google.com \
--cc=menage@google.com \
--cc=rohitseth@google.com \
--cc=sekharan@us.ibm.com \
--cc=winget@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox