From: David Brownell <david-b@pacbell.net>
To: linux-usb-devel@lists.sourceforge.net
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
Greg KH <gregkh@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [linux-usb-devel] [GIT PATCH] More USB patches for 2.6.18
Date: Thu, 28 Sep 2006 17:08:33 -0700 [thread overview]
Message-ID: <200609281708.34599.david-b@pacbell.net> (raw)
In-Reply-To: <20060928165951.2c5bd4c7.akpm@osdl.org>
> --- a/drivers/usb/host/ohci-hub.c~ohci-add-auto-stop-support-hack-hack
> +++ a/drivers/usb/host/ohci-hub.c
> @@ -132,6 +132,10 @@ static inline struct ed *find_head (stru
> return ed;
> }
>
> +#ifdef CONFIG_PM
> +static int ohci_restart(struct ohci_hcd *ohci);
> +#endif
> +
> /* caller has locked the root hub */
Better to just always include the forward decl... much cleaner!
... reviewing and testing those new OHCI changes is still on my
list; all that suspend stuff needs care, things that work on PCs don't
necessarily work on embedded hardware (where OHCI is common, and
PM tends to be more critical).
- Dave
next prev parent reply other threads:[~2006-09-29 0:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 22:42 [GIT PATCH] More USB patches for 2.6.18 Greg KH
2006-09-28 23:40 ` Linus Torvalds
2006-09-28 23:46 ` Greg KH
2006-09-28 23:59 ` Andrew Morton
2006-09-29 0:05 ` Greg KH
2006-09-29 0:07 ` Greg KH
2006-09-29 0:12 ` Andrew Morton
2006-09-29 0:08 ` David Brownell [this message]
2006-09-29 0:20 ` [linux-usb-devel] " Andrew Morton
2006-09-29 0:56 ` David Brownell
2006-09-29 16:01 ` Alan Stern
2006-09-29 0:51 ` Horst H. von Brand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200609281708.34599.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@osdl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox