From: Roger Gammans <roger@computer-surgery.co.uk>
To: linux-kernel@vger.kernel.org
Subject: fs/bio.c - Hardcoded sector size ?
Date: Thu, 28 Sep 2006 19:22:38 +0100 [thread overview]
Message-ID: <20060928182238.GA4759@julia.computer-surgery.co.uk> (raw)
Hi
In bio_endio() there is the follow line:-
bio->bi_sector += (bytes_done >> 9);
and there is a similiar line assuming a 512byte sector in
__bio_add_page() .
Is this a bug as the the actual block size should be available
from bio->bi_bdev->bd_block_size surely - or is some clever code
where all block devices have to translate back to 512 byte sectors
for bio s.
TTFN
--
Roger. Home| http://www.sandman.uklinux.net/
Master of Peng Shui. (Ancient oriental art of Penguin Arranging)
Work|Independent Sys Consultant | http://www.computer-surgery.co.uk/
So what are the eigenvalues and eigenvectors of 'The Matrix'? --anon
next reply other threads:[~2006-09-29 18:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 18:22 Roger Gammans [this message]
2006-09-29 18:38 ` fs/bio.c - Hardcoded sector size ? Randy Dunlap
2006-09-28 18:58 ` linux-kernel-owner
2006-09-29 19:11 ` Randy Dunlap
2006-09-28 19:19 ` Roger Gammans
2006-09-29 19:37 ` Randy Dunlap
2006-09-28 19:56 ` Roger Gammans
2006-09-29 20:17 ` Randy Dunlap
2006-09-29 20:22 ` Zach Brown
2006-09-29 20:32 ` Randy Dunlap
2006-09-29 17:25 ` Roger Gammans
2006-09-30 19:31 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060928182238.GA4759@julia.computer-surgery.co.uk \
--to=roger@computer-surgery.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox