Re: [RFC PATCH] move drm to pci_request_irq

Matthew Wilcox
2006-10-02T18:37:51Z

On Mon, Oct 02, 2006 at 08:12:29PM +0000, Frederik Deweerdt wrote:
>
> + pci_set_drvdata(dev, NULL);
> +
> DRM_DEBUG("lastclose completed\n");

Not necessary. pci_devs are allocated initialised to 0.

> @@ -132,8 +132,10 @@ static int drm_irq_install(drm_device_t
> if (drm_core_check_feature(dev, DRIVER_IRQ_SHARED))
> sh_flags = IRQF_SHARED;
>
> - ret = request_irq(dev->irq, dev->driver->irq_handler,
> - sh_flags, dev->devname, dev);
> + pci_set_drvdata(dev->pdev, dev);
> +
> + ret = pci_request_irq(dev->pdev, dev->driver->irq_handler,
> + sh_flags, dev->devname);

This seems like the wrong place to be setting the pci_drvdata. It
should probably be done in each driver. But then, requesting the IRQ
should also be done by each driver. You've dragged us into the "wow,
what a mess DRI is" black hole here, I'm afraid.