Re: [-mm patch] aic7xxx: check irq validity (was Re: 2.6.18-mm2)

Jeff Garzik
2006-10-01T19:20:10Z

Arjan van de Ven wrote:
> well... why not go one step further and eliminate the flags argument
> entirely? And use pci_name() for the name (so eliminate the argument ;)
> and always pass pdev as data, so that that argument can go away too....
>
> that'll cover 99% of the request_irq() users for pci devices.. and makes
> it really nicely simple and consistent.

Disagree. That would involve rewriting a lot of drivers.

flags: may or may not need sample-random flag.

name: is always the ethernet interface, for net drivers, or did you
forget from your irqbalance days? ;-)

data: in practice, is _rarely_ struct pci_dev. It's usually a
driver-private structure which is the structure most frequently
accessed. struct pci_dev* is rarely accessed inside the interrupt
handler, except maybe somewhere deep in an error handling path.

Jeff