From: Andrew Morton <akpm@osdl.org>
To: Thomas Gleixner <tglx@linutronix.de>, Dmitry Torokhov <dtor@mail.ru>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Jim Gettys <jg@laptop.org>, John Stultz <johnstul@us.ibm.com>,
David Woodhouse <dwmw2@infradead.org>,
Arjan van de Ven <arjan@infradead.org>,
Dave Jones <davej@redhat.com>
Subject: Re: [patch 23/23] dynticks: decrease I8042_POLL_PERIOD
Date: Sat, 30 Sep 2006 01:49:31 -0700 [thread overview]
Message-ID: <20060930014931.230c5fdb.akpm@osdl.org> (raw)
In-Reply-To: <20060929234441.435573000@cruncher.tec.linutronix.de>
On Fri, 29 Sep 2006 23:58:43 -0000
Thomas Gleixner <tglx@linutronix.de> wrote:
> From: Ingo Molnar <mingo@elte.hu>
>
> decrease the rate of timers going off. Also work around apparent
> kbd-init bug by making the first timeout short.
>
Again, please don't make unrelated kernel functions behave differently like
this.
>
> Index: linux-2.6.18-mm2/drivers/input/serio/i8042.c
> ===================================================================
> --- linux-2.6.18-mm2.orig/drivers/input/serio/i8042.c 2006-09-30 01:41:08.000000000 +0200
> +++ linux-2.6.18-mm2/drivers/input/serio/i8042.c 2006-09-30 01:41:20.000000000 +0200
> @@ -1101,7 +1101,7 @@ static int __devinit i8042_probe(struct
> goto err_controller_cleanup;
> }
>
> - mod_timer(&i8042_timer, jiffies + I8042_POLL_PERIOD);
> + mod_timer(&i8042_timer, jiffies + 2); //I8042_POLL_PERIOD);
> return 0;
>
> err_unregister_ports:
> Index: linux-2.6.18-mm2/drivers/input/serio/i8042.h
> ===================================================================
> --- linux-2.6.18-mm2.orig/drivers/input/serio/i8042.h 2006-09-30 01:41:08.000000000 +0200
> +++ linux-2.6.18-mm2/drivers/input/serio/i8042.h 2006-09-30 01:41:20.000000000 +0200
> @@ -43,7 +43,7 @@
> * polling.
> */
>
> -#define I8042_POLL_PERIOD HZ/20
> +#define I8042_POLL_PERIOD (10*HZ)
That's a huge change. Perhaps the interval was too short in the first
case. I guess waiting ten seconds for your keyboard or mouse to come to
life after hot-add is liveable with.
But whatever. This timer gets deleted in Dmitry's current development tree:
commit de9ce703c6b807b1dfef5942df4f2fadd0fdb67a
Author: Dmitry Torokhov <dtor@insightbb.com>
Date: Sun Sep 10 21:57:21 2006 -0400
Input: i8042 - get rid of polling timer
Remove polling timer that was used to detect keybord/mice hotplug and
register both IRQs right away instead of waiting for a driver to
attach to a port.
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
so problem solved.
next prev parent reply other threads:[~2006-09-30 8:56 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-29 23:58 [patch 00/23] Thomas Gleixner
2006-09-29 23:58 ` [patch 01/23] GTOD: exponential update_wall_time Thomas Gleixner
2006-09-29 23:58 ` [patch 02/23] GTOD: persistent clock support, core Thomas Gleixner
2006-09-30 8:35 ` Andrew Morton
2006-09-30 17:15 ` Jan Engelhardt
2006-10-02 21:49 ` john stultz
2006-09-29 23:58 ` [patch 03/23] GTOD: persistent clock support, i386 Thomas Gleixner
2006-09-30 8:36 ` Andrew Morton
2006-10-02 22:03 ` john stultz
2006-10-02 22:44 ` Andrew Morton
2006-10-02 23:09 ` john stultz
2006-10-03 23:30 ` Thomas Gleixner
2006-09-29 23:58 ` [patch 04/23] time: uninline jiffies.h Thomas Gleixner
2006-09-29 23:58 ` [patch 05/23] time: fix msecs_to_jiffies() bug Thomas Gleixner
2006-09-29 23:58 ` [patch 06/23] time: fix timeout overflow Thomas Gleixner
2006-09-29 23:58 ` [patch 07/23] cleanup: uninline irq_enter() and move it into a function Thomas Gleixner
2006-09-30 8:36 ` Andrew Morton
2006-09-29 23:58 ` [patch 08/23] dynticks: prepare the RCU code Thomas Gleixner
2006-09-30 8:36 ` Andrew Morton
2006-09-30 12:25 ` Dipankar Sarma
2006-09-30 13:09 ` Ingo Molnar
2006-09-30 13:52 ` Dipankar Sarma
2006-09-30 21:35 ` Ingo Molnar
2006-09-29 23:58 ` [patch 09/23] dynticks: extend next_timer_interrupt() to use a reference jiffie Thomas Gleixner
2006-09-30 8:37 ` Andrew Morton
2006-09-29 23:58 ` [patch 10/23] hrtimers: clean up locking Thomas Gleixner
2006-09-30 8:37 ` Andrew Morton
2006-09-29 23:58 ` [patch 11/23] hrtimers: state tracking Thomas Gleixner
2006-09-30 8:37 ` Andrew Morton
2006-09-29 23:58 ` [patch 12/23] hrtimers: clean up callback tracking Thomas Gleixner
2006-09-29 23:58 ` [patch 13/23] clockevents: core Thomas Gleixner
2006-09-30 8:39 ` Andrew Morton
2006-10-03 4:33 ` John Kacur
2006-09-29 23:58 ` [patch 14/23] clockevents: drivers for i386 Thomas Gleixner
2006-09-30 8:40 ` Andrew Morton
2006-09-29 23:58 ` [patch 15/23] high-res timers: core Thomas Gleixner
2006-09-30 8:43 ` Andrew Morton
2006-09-29 23:58 ` [patch 16/23] dynticks: core Thomas Gleixner
2006-09-30 8:44 ` Andrew Morton
2006-09-30 12:11 ` Dipankar Sarma
2006-09-29 23:58 ` [patch 17/23] dyntick: add nohz stats to /proc/stat Thomas Gleixner
2006-09-29 23:58 ` [patch 18/23] dynticks: i386 arch code Thomas Gleixner
2006-09-30 8:45 ` Andrew Morton
2006-09-29 23:58 ` [patch 19/23] high-res timers, dynticks: enable i386 support Thomas Gleixner
2006-09-29 23:58 ` [patch 20/23] add /proc/sys/kernel/timeout_granularity Thomas Gleixner
2006-09-30 8:45 ` Andrew Morton
2006-09-29 23:58 ` [patch 21/23] debugging feature: timer stats Thomas Gleixner
2006-09-30 8:46 ` Andrew Morton
2006-09-29 23:58 ` [patch 22/23] dynticks: increase SLAB timeouts Thomas Gleixner
2006-09-30 8:49 ` Andrew Morton
2006-09-29 23:58 ` [patch 23/23] dynticks: decrease I8042_POLL_PERIOD Thomas Gleixner
2006-09-30 8:49 ` Andrew Morton [this message]
2006-09-30 8:35 ` [patch 00/23] Andrew Morton
2006-09-30 19:17 ` Thomas Gleixner
2006-09-30 8:35 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060930014931.230c5fdb.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=davej@redhat.com \
--cc=dtor@mail.ru \
--cc=dwmw2@infradead.org \
--cc=jg@laptop.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox