From: Willy Tarreau <w@1wt.eu>
To: Olaf Hering <olaf@aepfle.de>
Cc: sam@ravnborg.org, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add XARGS to toplevel Makefile
Date: Sat, 30 Sep 2006 10:05:04 +0200 [thread overview]
Message-ID: <20060930080504.GO541@1wt.eu> (raw)
In-Reply-To: <20060930075427.GA6858@aepfle.de>
Hi Olaf,
On Sat, Sep 30, 2006 at 09:54:27AM +0200, Olaf Hering wrote:
>
> run xargs with --no-run-if-empty to avoid random failures:
>
> MAKE tags
> ctags: No files specified. Try "ctags --help".
> make: *** [tags] Error 123
> +# assume xargs comes from GNU findutils or GNU coreutils
> +XARGS = $(shell if [ "$$(uname -s)" = "Linux" ]; then echo "xargs --no-run-if-empty" ; else echo "xargs" ; fi )
I'd rather test xargs' support for the option than check the OS with uname.
Something like the following might a little bit be more appropriate :
XARGS = $(shell if xargs --no-run-if-empty true </dev/null 2>/dev/null; then echo "xargs --no-run-if-empty" ; else echo "xargs" ; fi )
Best regards,
Willy
prev parent reply other threads:[~2006-09-30 8:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 6:02 [PATCH] add XARGS to toplevel Makefile Olaf Hering
2006-09-28 8:33 ` Jan Engelhardt
2006-09-28 10:21 ` Sam Ravnborg
2006-09-28 10:55 ` Segher Boessenkool
2006-09-30 7:54 ` Olaf Hering
2006-09-30 8:05 ` Willy Tarreau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060930080504.GO541@1wt.eu \
--to=w@1wt.eu \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox