From: Pete Zaitcev <zaitcev@redhat.com>
To: linux-pcmcia@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, <fabrice@bellet.info>, zaitcev@redhat.com
Subject: pcmcia: patch to fix pccard_store_cis
Date: Sun, 1 Oct 2006 12:21:07 -0700 [thread overview]
Message-ID: <20061001122107.9260aa5d.zaitcev@redhat.com> (raw)
The ``ret'' obviously cannot be zero here, because it's initialized to the
write count and not zero.
For the complete description, see:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207910
Author: Fabrice Bellet <fabrice@bellet.info>
Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
--- linux-2.6.17.i686/drivers/pcmcia/socket_sysfs.c 2006-06-18 03:49:35.000000000 +0200
+++ /tmp/socket_sysfs.c 2006-10-01 19:30:09.000000000 +0200
@@ -321,7 +321,7 @@
kfree(cis);
- if (!ret) {
+ if (ret == count) {
mutex_lock(&s->skt_mutex);
if ((s->callback) && (s->state & SOCKET_PRESENT) &&
!(s->state & SOCKET_CARDBUS)) {
next reply other threads:[~2006-10-01 19:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-01 19:21 Pete Zaitcev [this message]
2006-10-02 0:31 ` pcmcia: patch to fix pccard_store_cis Dominik Brodowski
2006-10-02 13:01 ` Romano Giannetti
2006-11-03 16:02 ` Dominik Brodowski
2006-11-08 9:04 ` Romano Giannetti
2006-11-13 10:12 ` Romano Giannetti
2006-11-13 21:54 ` Romano Giannetti
[not found] ` <1163412159.11397.11.camel@localhost>
2006-11-13 21:54 ` pcmcia: patch to fix pccard_store_cis Was: [SOLUTION/HACK/PUZZLED] pcmcia modem only works with cardmgr in recent 2.6.15 kernel Andrew Morton
2006-11-13 22:48 ` Romano Giannetti
-- strict thread matches above, loose matches on Subject: below --
2006-11-13 23:40 pcmcia: patch to fix pccard_store_cis Daniel Ritz
2006-11-14 9:33 ` Romano Giannetti
2006-11-14 10:29 ` Romano Giannetti
2006-11-14 21:50 ` Daniel Ritz
2006-11-14 21:53 ` Dominik Brodowski
2006-11-14 22:41 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061001122107.9260aa5d.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=fabrice@bellet.info \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox