From: David Brownell <david-b@pacbell.net>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: B.Zolnierkiewicz@elka.pw.edu.pl,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [patch 2.6.18-git] ide-cs (CompactFlash) driver, rm irq warning
Date: Mon, 2 Oct 2006 11:58:59 -0700 [thread overview]
Message-ID: <200610021158.59886.david-b@pacbell.net> (raw)
In-Reply-To: <1159811149.8907.32.camel@localhost.localdomain>
On Monday 02 October 2006 10:45 am, Alan Cox wrote:
> Ar Llu, 2006-10-02 am 09:02 -0700, ysgrifennodd David Brownell:
> > Git rid of the runtime warning about pcmcia not supporting
> > exclusive IRQs, so "the driver needs updating".
> >
> > Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
>
> You've audited the code to check this is safely handled ?
As best I can, yes. IDE being somewhat black-boxish to most of us.
The patch literally does no more than shut up the warning found in
drivers/pcmcia/pcmcia_resource.c ... it doesn't change any other
behavior in the PCMCIA layer. And the IDE layer never appeared to
have a problem.
The IRQ handler seems to be drivers/ide/ide-io.c::ide_intr() and
comments there reflect the expectation that it handle shared IRQs.
- Dave
next prev parent reply other threads:[~2006-10-02 20:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-02 16:02 [patch 2.6.18-git] ide-cs (CompactFlash) driver, rm irq warning David Brownell
2006-10-02 17:45 ` Alan Cox
2006-10-02 18:58 ` David Brownell [this message]
2006-10-02 20:43 ` Alan Cox
2006-10-02 20:22 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610021158.59886.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox