From: Dmitry Torokhov <dtor@insightbb.com>
To: Lennart Poettering <mzxreary@0pointer.de>
Cc: len.brown@intel.com, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, s270-linux@mail.0pointer.de
Subject: Re: [PATCH] misc,acpi,backlight: MSI S270 Laptop support
Date: Mon, 2 Oct 2006 22:27:09 -0400 [thread overview]
Message-ID: <200610022227.10087.dtor@insightbb.com> (raw)
In-Reply-To: <20061003011056.GA28731@ecstasy.ring2.lan>
Hi Lennart,
On Monday 02 October 2006 21:10, Lennart Poettering wrote:
> +
> + msipf_device = platform_device_register_simple("msi-laptop-pf", -1, NULL, 0);
> + if (IS_ERR(msipf_device)) {
> + ret = PTR_ERR(msipf_device);
> + goto fail_platform_driver;
> + }
> +
Please do not use platform_device_register_simple, use platform_device_alloc
and platform_device_add instead (_simple will go away some day).
> + ret = sysfs_create_group(&msipf_device->dev.kobj, &msipf_attribute_group);
> + if (ret)
> + goto fail_platform_device;
> +
> +
> + /* Enable automatic brightness control again */
> + if (auto_brightness != 2)
> + set_auto_brightness(1);
> +
What happens if auto_brightness is 2 but userspace messed up with it
through device's sysfs attribute? Overall brightness controll interface
(module vs. per-device) needs to be tightened up.
--
Dmitry
next prev parent reply other threads:[~2006-10-03 2:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-03 1:10 [PATCH] misc,acpi,backlight: MSI S270 Laptop support Lennart Poettering
2006-10-03 1:48 ` Andrew Morton
2006-10-03 2:27 ` Dmitry Torokhov [this message]
2006-10-04 1:28 ` Lennart Poettering
2006-10-04 1:37 ` Dmitry Torokhov
2006-10-04 1:53 ` Lennart Poettering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610022227.10087.dtor@insightbb.com \
--to=dtor@insightbb.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mzxreary@0pointer.de \
--cc=s270-linux@mail.0pointer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox