Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386

Andrew Morton
2006-10-03T04:58:48Z

On Tue, 03 Oct 2006 14:49:39 +1000
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:

> On Mon, 2006-10-02 at 21:44 -0700, Andrew Morton wrote:
> > On Tue, 03 Oct 2006 14:37:25 +1000
> > Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >
> > > > > You might want to convince Andrew accepting my patch to make
> > > > > virt_to_bus/bus_to_virt give compile warnings on i386 for making
> > > > > people more aware of this problem...
> > > > >...
> > >
> > > Andrew, is there any reason not to take that patch ?
> >
> > It generates lots of warnings from drivers which nobody does any work on.
> >
> > Net result: lots of new warnings, no fixed bugs.
>
> Are you sure the warnings won't cause somebody like Al to go through
> them all and fix them ?

The drivers simply don't link on some architectures, due to missing
virt_to_bus/bus_to_virt. They aren't hard to find.

> At least they should be marked either CONFIG_BROKEN or X86 only (or
> whatever arch they are supposed to be used on).
>

Something like that would make sense. I guess a new config option.