public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [patch] mm: Fix incorrect mempolicy for idle threads
@ 2006-10-03  2:49 Ravikiran G Thirumalai
  0 siblings, 0 replies; only message in thread
From: Ravikiran G Thirumalai @ 2006-10-03  2:49 UTC (permalink / raw)
  To: Andrew Morton
  Cc: linux-kernel, Alok Kataria, Shai Fultheim (Shai@scalex86.org),
	Benzi Galili (Benzi@ScaleMP.com)

The kernel boots up on the BP with an initial memory policy of
MPOL_INTERLEAVE (start_kernel() -> numa_policy_init()).  This is
done to avoid all boot data structure allocations to be off the boot
node. Current mainline resets the memory policy to MPOL_DEFAULT at init(), 
just before calling userspace init.  But, this is too late and leaves 
the kernel idle thread with MPOL_INTERLEAVE, causing later allocations 
off interrupt/BH context to use MPOL_INTERLEAVE, rather than MPOL_DEFAULT 
(if the interrupt occurs on an idle cpu).  This can be fixed by changing 
the mempolicy to MPOL_DEFAULT just before the 'init' kernel thread is 
spawned, OR just before smp_init() (smp_init would spawn idle threads).  
The following patch uses the latter approach and moves numa_default_policy() 
to just  before smp_init().

Signed-off-by: Alok N Kataria <alok.kataria@calsoftinc.com>
Signed-off-by: Ravikiran Thirumalai <kiran@scalex86.org>
Signed-off-by: Shai Fultheim <shai@scalex86.org>

Index: linux-2.6.18/init/main.c
===================================================================
--- linux-2.6.18.orig/init/main.c	2006-09-19 20:42:06.000000000 -0700
+++ linux-2.6.18/init/main.c	2006-09-28 15:13:01.000000000 -0700
@@ -703,6 +703,8 @@ static int init(void * unused)
 
 	do_pre_smp_initcalls();
 
+	numa_default_policy();
+
 	smp_init();
 	sched_init_smp();
 
@@ -738,7 +740,6 @@ static int init(void * unused)
 	unlock_kernel();
 	mark_rodata_ro();
 	system_state = SYSTEM_RUNNING;
-	numa_default_policy();
 
 	if (sys_open((const char __user *) "/dev/console", O_RDWR, 0) < 0)
 		printk(KERN_WARNING "Warning: unable to open an initial console.\n");

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-10-03  2:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-03  2:49 [patch] mm: Fix incorrect mempolicy for idle threads Ravikiran G Thirumalai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox