From: Andrew Morton <akpm@osdl.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kirill Korotaev <dev@openvz.org>,
Pavel Emelianov <xemul@openvz.org>,
Cedric Le Goater <clg@fr.ibm.com>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH] IPC namespace core
Date: Tue, 3 Oct 2006 09:35:05 -0700 [thread overview]
Message-ID: <20061003093505.0bb7bb6a.akpm@osdl.org> (raw)
In-Reply-To: <1159866174.3438.66.camel@pmac.infradead.org>
On Tue, 03 Oct 2006 10:02:54 +0100
David Woodhouse <dwmw2@infradead.org> wrote:
> You need to move the #include down the file by about 50 lines so it
> lands inside the existing #ifdef __KERNEL__.
>
> All those signed-off-bys and _none_ of you managed to notice that
> <linux/kref.h> doesn't exist in the headers we export to userspace,
> despite the fact that just running 'make headers_check' would have
> shouted at you about it?
>
> Bad hacker. No biscuit.
We'll get there ;) I'm waiting for a suitable time to merge
add-config_headers_check-option-to-automatically-run-make-headers_check.patch,
which will cause all `make allmodconfig' testers to automatically run `make
headers_check'.
But I don't think the time is right yet - a little later, when things have
settled down and when it all works nicely on multiple architectures.
next prev parent reply other threads:[~2006-10-03 16:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200610021601.k92G13mT003934@hera.kernel.org>
2006-10-03 9:02 ` [PATCH] IPC namespace core David Woodhouse
2006-10-03 10:06 ` Cedric Le Goater
2006-10-03 13:38 ` Eric W. Biederman
2006-10-03 16:35 ` Andrew Morton [this message]
2006-10-03 22:01 ` David Woodhouse
2006-10-03 22:49 ` Andrew Morton
2006-10-03 22:51 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061003093505.0bb7bb6a.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=clg@fr.ibm.com \
--cc=dev@openvz.org \
--cc=dwmw2@infradead.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox