Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage

Andrew Morton
2006-10-10T18:46:50Z

On Tue, 10 Oct 2006 10:30:44 -0400
Vivek Goyal <vgoyal@in.ibm.com> wrote:

> On Mon, Oct 09, 2006 at 08:14:18PM -0700, Andrew Morton wrote:
> > On Mon, 9 Oct 2006 10:33:45 -0400
> > Vivek Goyal <vgoyal@in.ibm.com> wrote:
> >
> > > Please find attached the regenerated patch.
> >
> > Somewhere amongst the six versions of this patch, the kernel broke. Seems
> > that the kernel command line isn't getting recognised. The machine is
> > running LILO and RH FC1.
> >
> > I'll consolidate the patches which I have now and then I'll drop them.
> >
>
> Hi Andrew,
>
> I will find a machine having lilo and look into the issue.

Thanks.

> Instead of dropping all the patches, can't we just drop the last patch which
> adds an elf header.

Yes, that patch was the cause.

> Most likely this issue should be happening because of
> that patch. Rest of the patches should be harmless.

Those patches had reached my tolerance threshold and other people want to
make changes to vmlinux.lds.S, and having large and uncertain changes in
there makes that harder for them.

Resend them when you think they're ready for another run please.