Re: [PATCH 4/12] i386: define __pa_symbol()

Franck Bui-Huu
2006-10-04T08:25:46Z

hi,

Sorry for the late feedback...

Vivek Goyal wrote:
>
> On x86_64 we have to be careful with calculating the physical
> address of kernel symbols. Both because of compiler odditities
> and because the symbols live in a different range of the virtual
> address space.
>

[snip]

> +#define __pa_symbol(x) \
> + ({unsigned long v; \
> + asm("" : "=r" (v) : "0" (x)); \
> + __pa(v); })

Why not simply reusing RELOC_HIDE like this ?

#define __pa_symbol(x) __pa(RELOC_HIDE(x,0))

thanks
Franck