From: Paul Jackson <pj@sgi.com>
To: Joe Korty <joe.korty@ccur.com>
Cc: akpm@osdl.org, reinette.chatre@linux.intel.com,
linux-kernel@vger.kernel.org, inaky@linux.intel.com
Subject: Re: [PATCH] bitmap: bitmap_parse takes a kernel buffer instead of a user buffer
Date: Wed, 4 Oct 2006 08:06:37 -0700 [thread overview]
Message-ID: <20061004080637.0bd19042.pj@sgi.com> (raw)
In-Reply-To: <20061004145524.GA24335@tsunami.ccur.com>
Joe wrote:
> I guess I am a sucker for no-transient-buffer (bufferless?)
Ah - that explains Joe's preference for putting the actual implementing
code in the user version - it gets to pull in the user string one
char at a time, avoiding a malloc'd buffer.
I tend to make more coding mistakes that way, so have gotten in the
habit of keeping my scanning code separate from any code required to
get a nice safe local copy of the input that is to be scanned.
I agree with Joe - either way can be made to work - author's
discretion. Just be sure to impose that sanity limit.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
next prev parent reply other threads:[~2006-10-04 15:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-03 15:16 [PATCH] bitmap: bitmap_parse takes a kernel buffer instead of a user buffer Reinette Chatre
2006-10-03 15:20 ` inaky
2006-10-03 23:39 ` Andrew Morton
2006-10-04 2:03 ` Paul Jackson
2006-10-04 14:14 ` Joe Korty
2006-10-04 14:27 ` Paul Jackson
2006-10-04 14:55 ` Joe Korty
2006-10-04 15:06 ` Paul Jackson [this message]
2006-10-04 15:52 ` inaky
2006-10-04 16:40 ` Andrew Morton
2006-10-04 17:14 ` Joe Korty
2006-10-04 17:57 ` Inaky Perez-Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061004080637.0bd19042.pj@sgi.com \
--to=pj@sgi.com \
--cc=akpm@osdl.org \
--cc=inaky@linux.intel.com \
--cc=joe.korty@ccur.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reinette.chatre@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox