From: Joe Korty <joe.korty@ccur.com>
To: Paul Jackson <pj@sgi.com>
Cc: akpm@osdl.org, reinette.chatre@linux.intel.com,
linux-kernel@vger.kernel.org, inaky@linux.intel.com
Subject: Re: [PATCH] bitmap: bitmap_parse takes a kernel buffer instead of a user buffer
Date: Wed, 4 Oct 2006 10:55:24 -0400 [thread overview]
Message-ID: <20061004145524.GA24335@tsunami.ccur.com> (raw)
In-Reply-To: <20061004072746.8e4b97a0.pj@sgi.com>
On Wed, Oct 04, 2006 at 07:27:46AM -0700, Paul Jackson wrote:
> Perhaps I should have my coffee first, but I don't see where the
> order in which we wrap these affects the need to impose a crude
> upper limit on what the user can ask for.
>
> Off hand, I'd expect the kernel version to be the actual implementing
> code, and the user version to be the wrapper and also to impose the
> crude upper limit.
I guess I am a sucker for no-transient-buffer (bufferless?)
implementations, as with them there is an intrinsic
simplicity that automatically avoids problems. The price
in this case, though, is the use of the more expensive
get_user() where, for kernel buffers, it is not needed.
I have no objection though, and in either case we should
impose a sanity check on 'count'.
Joe
next prev parent reply other threads:[~2006-10-04 14:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-03 15:16 [PATCH] bitmap: bitmap_parse takes a kernel buffer instead of a user buffer Reinette Chatre
2006-10-03 15:20 ` inaky
2006-10-03 23:39 ` Andrew Morton
2006-10-04 2:03 ` Paul Jackson
2006-10-04 14:14 ` Joe Korty
2006-10-04 14:27 ` Paul Jackson
2006-10-04 14:55 ` Joe Korty [this message]
2006-10-04 15:06 ` Paul Jackson
2006-10-04 15:52 ` inaky
2006-10-04 16:40 ` Andrew Morton
2006-10-04 17:14 ` Joe Korty
2006-10-04 17:57 ` Inaky Perez-Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061004145524.GA24335@tsunami.ccur.com \
--to=joe.korty@ccur.com \
--cc=akpm@osdl.org \
--cc=inaky@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
--cc=reinette.chatre@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox