Re: [PATCH 6/12] i386: CONFIG_PHYSICAL_START cleanup

Eric W. Biederman
2006-10-03T19:02:07Z

Dave Hansen <haveblue@us.ibm.com> writes:

> On Tue, 2006-10-03 at 13:15 -0400, Vivek Goyal wrote:
>> diff -puN arch/i386/boot/compressed/misc.c~i386-CONFIG_PHYSICAL_START-cleanup
> arch/i386/boot/compressed/misc.c
>> ---
> linux-2.6.18-git17/arch/i386/boot/compressed/misc.c~i386-CONFIG_PHYSICAL_START-cleanup
> 2006-10-02 13:17:58.000000000 -0400
>> +++ linux-2.6.18-git17-root/arch/i386/boot/compressed/misc.c 2006-10-02
> 14:33:44.000000000 -0400
>> @@ -9,11 +9,11 @@
>> * High loaded stuff by Hans Lermen & Werner Almesberger, Feb. 1996
>> */
>>
>> +#include <linux/config.h>
>> #include <linux/linkage.h>
>> #include <linux/vmalloc.h>
>> #include <linux/screen_info.h>
>
> Isn't config.h implicitly included everywhere by the build system now?
> I don't think this is needed.

It should be.

That is one of the issues I received feedback on, the first round.

Eric