Re: [PATCH 1/3] UEAGLE : be suspend friendly

[Duncan Sands <baldrick@free.fr>]

Hi Pavel,

> > Signed-off-by: matthieu castet <castet.matthieu@free.fr>
> > Index: linux/drivers/usb/atm/ueagle-atm.c
> > ===================================================================
> > --- linux.orig/drivers/usb/atm/ueagle-atm.c	2006-09-22 21:39:56.000000000 +0200
> > +++ linux/drivers/usb/atm/ueagle-atm.c	2006-09-22 21:40:45.000000000 +0200
> > @@ -1177,6 +1177,9 @@
> >  			ret = uea_stat(sc);
> >  		if (ret != -EAGAIN)
> >  			msleep(1000);
> > + 		if (try_to_freeze())
> > +			uea_err(INS_TO_USBDEV(sc), "suspend/resume not supported, "
> > +				"please unplug/replug your modem\n");
> 
> Plug/unplug should be easy enough to simulate from usb driver, no?

if a USB driver doesn't define suspend/resume methods, then the core simply
unplugs it on suspend, and replugs on resume (IIRC).  Maybe Matthieu is trying
for something better - hopefully he will explain.  Since this is a modem, it
would be nice if the internet connection sprang back to life on resume, which
requires more work than unplug/plug.  I've no idea what needs to be done to achieve
this.  These modems use the ATM networking layer by the way, I don't know if that
makes things easier or harder.

Ciao,

Duncan.