From: Greg KH <gregkh@suse.de>
To: Jarek Poplawski <jarkao2@o2.pl>,
"Axel C. Voigt" <Axel.Voigt@qosmotec.com>,
linux-kernel@vger.kernel.org, David Kubicek <dave@awk.cz>
Subject: Re: Problems with hard irq? (inconsistent lock state)
Date: Thu, 5 Oct 2006 11:05:44 -0700 [thread overview]
Message-ID: <20061005180544.GC15199@suse.de> (raw)
In-Reply-To: <20061004064542.GA2649@ff.dom.local>
On Wed, Oct 04, 2006 at 08:45:43AM +0200, Jarek Poplawski wrote:
> On Tue, Oct 03, 2006 at 10:43:09PM -0700, Greg KH wrote:
> > On Wed, Oct 04, 2006 at 07:43:08AM +0200, Jarek Poplawski wrote:
> > > On 29-09-2006 13:45, Axel C. Voigt wrote:
> ...
> > > > Sep 29 13:29:53 mcs70 kernel: =================================
> > > > Sep 29 13:29:53 mcs70 kernel: [ INFO: inconsistent lock state ]
> > > > Sep 29 13:29:53 mcs70 kernel: ---------------------------------
> > > > Sep 29 13:29:53 mcs70 kernel: inconsistent {hardirq-on-W} -> {in-hardirq-W} usage.
> > > > Sep 29 13:29:53 mcs70 kernel: startDV24/3864 [HC1[1]:SC0[0]:HE0:SE1] takes:
> > > > Sep 29 13:29:53 mcs70 kernel: (&acm->read_lock){++..}, at: [<e08952d8>] acm_read_bulk+0x60/0xde [cdc_acm]
> > > > Sep 29 13:29:53 mcs70 kernel: {hardirq-on-W} state was registered at:
> ...
> > > It looks in drivers/usb/class/cdc-acm.c acm_rx_tasklet could be preempted
> > > with acm->read_lock by acm_read_bulk which uses the same lock from hardirq
> > > context.
> > >
> > > So probably spin_lock_irqsave is needed.
> >
> > Yup. Care to send a patch?
>
> If it could help?
Great, care to resend this to me with a signed-off-by: line?
thanks,
greg k-h
next prev parent reply other threads:[~2006-10-05 18:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-29 11:45 Problems with hard irq? (inconsistent lock state) Axel C. Voigt
2006-10-04 5:43 ` Jarek Poplawski
2006-10-04 5:43 ` Greg KH
2006-10-04 6:45 ` Jarek Poplawski
2006-10-05 18:05 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-10-04 20:58 Axel C. Voigt
2006-10-05 8:39 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061005180544.GC15199@suse.de \
--to=gregkh@suse.de \
--cc=Axel.Voigt@qosmotec.com \
--cc=dave@awk.cz \
--cc=jarkao2@o2.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox