From: Andrew Morton <akpm@osdl.org>
To: Vadim Lobanov <vlobanov@speakeasy.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] fdtable: Extensive fs/file.c cleanups.
Date: Fri, 6 Oct 2006 13:22:58 -0700 [thread overview]
Message-ID: <20061006132258.39fc58ed.akpm@osdl.org> (raw)
In-Reply-To: <200610052152.29013.vlobanov@speakeasy.net>
On Thu, 5 Oct 2006 21:52:28 -0700
Vadim Lobanov <vlobanov@speakeasy.net> wrote:
> As long as the previous patch replaces the guts of fs/file.c, it makes sense
> to tidy up all the code within. This work includes:
> code simplification via refactoring,
> elimination of unnecessary code paths,
> extensive commenting throughout the entire file, and
> other minor cleanups and consistency tweaks.
> This patch does not contain any functional modifications.
>
> This is the last patch in the series. All the code should now be sparkly
> clean.
This (wordwrapped) patch should have been the first in the series, not the
last. Having the substantive changes come after the cleanups makes
subsequent problem diagnosis simpler, means we have less code to revert if
it goes bad, etc.
So I'll drop this one.
next prev parent reply other threads:[~2006-10-06 20:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 4:52 [PATCH 5/5] fdtable: Extensive fs/file.c cleanups Vadim Lobanov
2006-10-06 20:22 ` Andrew Morton [this message]
2006-10-06 21:38 ` Vadim Lobanov
2006-10-06 22:42 ` Andrew Morton
2006-10-06 23:08 ` Vadim Lobanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061006132258.39fc58ed.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vlobanov@speakeasy.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox