From: Matthew Wilcox <matthew@wil.cx>
To: Jeff Garzik <jeff@garzik.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [PATCH] Rename pdc_init
Date: Fri, 6 Oct 2006 11:03:31 -0600 [thread overview]
Message-ID: <20061006170331.GJ2563@parisc-linux.org> (raw)
In-Reply-To: <4526876A.5090103@garzik.org>
On Fri, Oct 06, 2006 at 12:42:18PM -0400, Jeff Garzik wrote:
> I don't mind the patch (you should have CC'd me and linux-ide though),
We really need to figure out how to communicate that better. I just
sent it to the maintainer (as listed in MODULE_AUTHOR). Do we need a
MODULE_CHANGES_CC macro too?
> but where is parisc's pdc_init actually used, and why is it global?
Hmm. Embarrassing. Seems it's a stale prototype; I'll delete it.
OTOH, there is a pdc_init in avr32, and it's prudent to not have two
functions of the same name, so that you know which one is appearing in a
backtrace. So it might be a good idea to apply this patch anyway.
next prev parent reply other threads:[~2006-10-06 17:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 16:12 [PATCH] [PATCH] Rename pdc_init Matthew Wilcox
2006-10-06 16:42 ` Jeff Garzik
2006-10-06 17:03 ` Matthew Wilcox [this message]
2006-10-06 17:30 ` Alan Cox
2006-10-06 17:07 ` Matthew Wilcox
2006-10-06 17:43 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061006170331.GJ2563@parisc-linux.org \
--to=matthew@wil.cx \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox