[KJ] [PATCH] sound/isa/gus/interwave.c: check kmalloc() return value.

[KJ] [PATCH] sound/isa/gus/interwave.c: check kmalloc() return value.

[Amit Choudhary]

Description: Check the return value of kmalloc() in function snd_interwave_pnp(), in file sound/isa/gus/interwave.c.

Signed-off-by: Amit Choudhary <amit2030@gmail.com>

diff --git a/sound/isa/gus/interwave.c b/sound/isa/gus/interwave.c
index ea69f25..5282fbb 100644
--- a/sound/isa/gus/interwave.c
+++ b/sound/isa/gus/interwave.c
@@ -564,6 +564,8 @@ static int __devinit snd_interwave_pnp(i
 	struct pnp_resource_table * cfg = kmalloc(sizeof(struct pnp_resource_table), GFP_KERNEL);
 	int err;
 
+	if (!cfg)
+		return -ENOMEM;
 	iwcard->dev = pnp_request_card_device(card, id->devs[0].id, NULL);
 	if (iwcard->dev == NULL) {
 		kfree(cfg);

Re: [KJ] [PATCH] sound/isa/gus/interwave.c: check kmalloc() return value.

[Takashi Iwai]

At Sat, 7 Oct 2006 00:31:55 -0700,
Amit Choudhary wrote:
> 
> Description: Check the return value of kmalloc() in function snd_interwave_pnp(), in file sound/isa/gus/interwave.c.
> 
> Signed-off-by: Amit Choudhary <amit2030@gmail.com>

Thanks, I merged these patches to ALSA tree now.


Takashi

> 
> diff --git a/sound/isa/gus/interwave.c b/sound/isa/gus/interwave.c
> index ea69f25..5282fbb 100644
> --- a/sound/isa/gus/interwave.c
> +++ b/sound/isa/gus/interwave.c
> @@ -564,6 +564,8 @@ static int __devinit snd_interwave_pnp(i
>  	struct pnp_resource_table * cfg = kmalloc(sizeof(struct pnp_resource_table), GFP_KERNEL);
>  	int err;
>  
> +	if (!cfg)
> +		return -ENOMEM;
>  	iwcard->dev = pnp_request_card_device(card, id->devs[0].id, NULL);
>  	if (iwcard->dev == NULL) {
>  		kfree(cfg);
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>