From: Grant Grundler <grundler@parisc-linux.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: Matthew Wilcox <matthew@wil.cx>,
Val Henson <val_henson@linux.intel.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
netdev@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: [PATCH 2/2] [TULIP] Check the return value from pci_set_mwi()
Date: Fri, 6 Oct 2006 23:34:48 -0600 [thread overview]
Message-ID: <20061007053448.GC3314@colo.lackof.org> (raw)
In-Reply-To: <4526B5BD.4030809@garzik.org>
On Fri, Oct 06, 2006 at 03:59:57PM -0400, Jeff Garzik wrote:
> The unmodified tulip driver checks both MWI and cacheline-size because
> one of the clones (PNIC or PNIC2) will let you set the MWI bit, but
> hardwires cacheline size to zero.
Maybe the generic pci_set_mwi() can verify cacheline size is non-zero?
I don't think each driver should need to enforce this.
> If the arches do not behave consistently, we need to keep the check in
> the tulip driver, to avoid incorrectly programming the csr0 MWI bit.
Why not fix the arches to be consistent?
There's alot more drivers than arches...and we have control
of the arch specific PCI support.
thanks,
grant
next prev parent reply other threads:[~2006-10-07 5:34 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 19:05 [PATCH 1/2] [PCI] Check that MWI bit really did get set Matthew Wilcox
2006-10-06 19:05 ` [PATCH 2/2] [TULIP] Check the return value from pci_set_mwi() Matthew Wilcox
2006-10-06 19:15 ` Jeff Garzik
2006-10-06 19:28 ` Matthew Wilcox
2006-10-06 19:59 ` Jeff Garzik
2006-10-07 5:34 ` Grant Grundler [this message]
2006-10-07 14:44 ` Jeff Garzik
2006-10-06 19:16 ` [PATCH 1/2] [PCI] Check that MWI bit really did get set Jeff Garzik
2006-10-14 4:41 ` Andrew Morton
2006-10-14 5:21 ` Greg KH
2006-10-14 14:02 ` Matthew Wilcox
2006-10-14 20:48 ` Andrew Morton
2006-10-15 3:20 ` Matthew Wilcox
2006-10-15 6:53 ` Andrew Morton
2006-10-15 13:54 ` Matthew Wilcox
2006-10-15 17:47 ` Andrew Morton
2006-10-15 7:08 ` [Bulk] " David Brownell
2006-10-15 13:52 ` Matthew Wilcox
2006-10-15 14:21 ` Alan Cox
2006-10-15 13:57 ` Matthew Wilcox
2006-10-15 17:45 ` Andrew Morton
2006-10-15 19:16 ` David Brownell
2006-10-15 19:34 ` Andrew Morton
2006-10-15 22:45 ` David Brownell
2006-10-15 23:18 ` Andrew Morton
2006-10-16 0:02 ` Alan Cox
2006-10-15 23:44 ` Andrew Morton
2006-10-16 0:44 ` Paul Mackerras
2006-10-16 1:10 ` Andrew Morton
2006-10-16 2:07 ` David Brownell
2006-10-16 10:58 ` Alan Cox
2006-10-16 11:02 ` Alan Cox
2006-10-16 0:16 ` David Brownell
2006-10-16 0:31 ` Andrew Morton
2006-10-16 10:59 ` Alan Cox
2006-10-15 21:52 ` [Bulk] " Alan Cox
2006-10-16 0:00 ` Paul Mackerras
2006-10-16 0:15 ` Andrew Morton
2006-10-16 0:21 ` David Brownell
[not found] <fa.5vbPpPQ5p6Rqb6w5IQvYeIEZ+o4@ifi.uio.no>
[not found] ` <fa.5fHFiSyxiA8IzX/z36b4ccRdkwk@ifi.uio.no>
[not found] ` <fa.xexLYpZ2s3jlzi3H4j8CMu5nU5M@ifi.uio.no>
[not found] ` <fa.DScE5F/ioZsTJQxVaKgCvzyY/+o@ifi.uio.no>
[not found] ` <fa.lMwhGlM7h3gT94gAUyYURPCF1Qg@ifi.uio.no>
2006-10-07 0:15 ` [PATCH 2/2] [TULIP] Check the return value from pci_set_mwi() Robert Hancock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061007053448.GC3314@colo.lackof.org \
--to=grundler@parisc-linux.org \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=matthew@wil.cx \
--cc=netdev@vger.kernel.org \
--cc=val_henson@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox